Bug #35895 for Getopt-Euclid: Bug with line delimeters (tests and fix included)

Wed May 14 19:23:35 2008 bitcard_ok [...] alvar.a-blast.org - Ticket created

Subject:

Bug with line delimeters (tests and fix included)

Hi, Getopt::Euclid (Getopt-Euclid-v0.2.0) has a critical bug with line delimeters: When using a file with Unix line endings, no options are recognised when the script (or module) runs on Windows and vice versa. The result is, that the same files can not run on Windows AND Unix. There is no error message. All options are simply ignored. :-( Attached there is a diff with the following changes and the complete distribution with: * Tests, which show the bugs - t/line_delimeters-unix.t - t/line_delimeters-windows.t - t/line_delimeters-mac-os-classic.t * A fixed version of lib/Getopt/Euclid.pm * diff with all changes: getopt-euclid-newline-patch.diff The changes begin in line 83: # # Clean up line delimeters: # Windows : \x0D\x0A # Unix : \x0A # MacOS Classic: \x0D # # => Replace them by native line ending on this platform: \n # my $LINE_DELIMETERS = qr{ \x0D? \x0A | \x0D }xms; $source =~ s{ $LINE_DELIMETERS }{\n}gxms; map { s{ $LINE_DELIMETERS }{\n}gxms; } @std_POD; It would be good if the bug gets fixed soon in the version distributed via CPAN. BTW: There is another "bug": The documentation sais that "no bugs have been reported" -- this is not true, there are some bugs in RT ... Ciao Alvar -- ** Alvar C.H. Freude ** http://alvar.a-blast.org/ ** http://www.perl-blog.de/

Subject:

getopt-euclid-newline-patch.tar.gz

Download getopt-euclid-newline-patch.tar.gz
application/x-gzip 28.4k

Message body not shown because it is not plain text.

Sun May 31 10:31:31 2009 kgalinsky [...] gmail.com - Correspondence added

Hi Alvar, I ran the tests against the version of Getopt::Euclid I am getting ready to release, which hasn't had your patch applied. It passed the tests, which makes them seem dubious... Anyway, I'll release 0.2.1 without addressing this bug, but will look into the issue. -Kevin

Sun May 31 10:31:32 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 01 04:00:23 2009 bitcard_ok [...] alvar.a-blast.org - Correspondence added

From:

bitcard_ok [...] alvar.a-blast.org

Hi, On So. 31. Mai 2009, 10:31:31, kgalinsky wrote: Show quoted text

> I ran the tests against the version of Getopt::Euclid I am getting ready > to release, which hasn't had your patch applied. It passed the tests, > which makes them seem dubious... Anyway, I'll release 0.2.1 without > addressing this bug, but will look into the issue.

hmmm; perhaps this depends on the OS you are using. It is some time ago that I build the patch ... But, nevertheless: thanks for taking the maintainership of this module and fixing bugs! Attached I send you my version of Getopt::Euclid, which has some more changes included then the patch above -- it now works with PAR and the strange message with enabled ithreads is fixed. (#35147, #37182) Ciao Alvar

Message body is not shown because it is too large.

Mon Jun 01 04:19:43 2009 bitcard_ok [...] alvar.a-blast.org - Correspondence added

On Mo. 01. Jun. 2009, 04:00:23, alvar-f wrote: Show quoted text

> hmmm; perhaps this depends on the OS you are using. It is some time > ago that I build the > patch ...

strange ... Now I run the tests against an unpatched version of Getopt::Euclid, and the tests pass (OS X with native Unix line endings). It seems that the tests are buggy ... But the bug is there ;) and the patch fixes it. Ciao Alvar

Thu Sep 09 19:13:57 2010 kgalinsky [...] gmail.com - Correspondence added

Including the following code snippet into Euclid 2.2 which should do the same as your code but is more readable: # Clean up line delimeters s{ [\n\r] }{\n}gx foreach ($source, @std_POD);

Thu Sep 09 19:15:37 2010 kgalinsky [...] gmail.com - Status changed from 'open' to 'patched'

Fri Sep 10 12:07:32 2010 kgalinsky [...] gmail.com - Status changed from 'patched' to 'resolved'

Fri Sep 10 12:07:33 2010 kgalinsky [...] gmail.com - Fixed in v0.2.2 added