Bug #35868 for SQL-Translator: SQL::Translator::Parser::DBI should not disconnect $dbh

Wed May 14 03:05:39 2008 chris+rt [...] chrisdolan.net - Ticket created

Subject:

SQL::Translator::Parser::DBI should not disconnect $dbh

In my Catalyst/DBIx::Class application, I generate and apply sql diffs automatically at startup. However, the SQL::Translator::Parser::DBI class calls "$dbh->disconnect" which tears down my database connection prematurely. That class should take a RAII approach and make the caller take care of disconnecting the database.

Wed May 14 03:21:09 2008 chris+rt [...] chrisdolan.net - Correspondence added

On Wed May 14 03:05:39 2008, CDOLAN wrote: Show quoted text

> In my Catalyst/DBIx::Class application, I generate and apply sql diffs > automatically at startup. However, the SQL::Translator::Parser::DBI > class calls "$dbh->disconnect" which tears down my database connection > prematurely. That class should take a RAII approach and make the caller > take care of disconnecting the database.

Looking more closely at the code, the best fix is probably this: Old: $dbh->disconnect if defined $dbh; New: $dbh->disconnect if defined $dbh && ! defined $args->{'dbh'};

Wed May 14 03:21:11 2008 chris+rt [...] chrisdolan.net - Status changed from 'new' to 'open'

Fri Apr 27 22:03:32 2012 ribasushi [...] leporine.io - Correspondence added

Finally patched up: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits/SQL-Translator.git;a=commitdiff;h=c3919fdd12bd325e67f705e82aaf355940bc861b

Fri Apr 27 22:03:34 2012 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'

Thu May 10 02:21:28 2012 ribasushi [...] leporine.io - Fixed in 0.11011 added

Thu May 10 02:21:28 2012 ribasushi [...] leporine.io - Fixed in 0.09000 deleted

Thu May 10 02:21:28 2012 ribasushi [...] leporine.io - Status changed from 'patched' to 'resolved'