Skip Menu |

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 35837
Status: resolved
Priority: 0/
Queue: DBD-Pg

People
Owner: Nobody in particular
Requestors: bohica [...] ntlworld.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.2.0
Fixed in: 2.7.2



Subject: parse_trace_flag example in pod wrong
I believe the pod: $h->trace($h->parse_trace_flag('SQL|pglibpq')); $h->trace($h->parse_trace_flag('1|pgstart')); is wrong as it is attempting to parse multiple flags with parse_trace_flag and it should be parse_trace_flags (note the s). As an aside (and I have not tested this myself) I'm not sure the DBD::Pg::parse_trace_flag code is correct as it does: return DBI::parse_trace_flag($dbh, $flag); but pops $class and $flag off @_ so shouldn't that $dbh really be $class? Martin -- Martin J. Evans Wetherby, UK
Subject: Re: [rt.cpan.org #35837] parse_trace_flag example in pod wrong
Date: Tue, 13 May 2008 15:01:05 -0000
To: bug-DBD-Pg [...] rt.cpan.org
From: "Greg Sabino Mullane" <greg [...] turnstep.com>
-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 Show quoted text
> I believe the pod ... is wrong
Thanks, fixed. Show quoted text
> As an aside (and I have not tested this myself) I'm not sure the > DBD::Pg::parse_trace_flag code is correct as it does: > > return DBI::parse_trace_flag($dbh, $flag); > > but pops $class and $flag off @_ so shouldn't that $dbh really be $class?
Yes, it should, thanks. - -- Greg Sabino Mullane greg@turnstep.com End Point Corporation PGP Key: 0x14964AC8 200805131100 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -----BEGIN PGP SIGNATURE----- iEYEAREDAAYFAkgprPgACgkQvJuQZxSWSsjGuwCg+tA6+hNj0NsVsR3P6yZ3c1rm ye4AoOnxzMGsKoyWsQMF3Z6yCtdFUcj6 =X3g2 -----END PGP SIGNATURE-----