Bug #35825 for Devel-Cycle: Bug in handling GLOBs

Mon May 12 18:39:58 2008 greg [...] blekko.com - Ticket created

CC:	rich [...] blekko.com
Subject:	Bug in handling GLOBs
Date:	Mon, 12 May 2008 15:39:56 -0700
To:	bug-Devel-Cycle [...] rt.cpan.org
From:	Greg Lindahl <greg [...] blekko.com>

Devel::Cycle doesn't handle type GLOB. In fact it gives an obscure error when you hand it something with a GLOB: Undefined subroutine &Devel::Cycle::_find_cycle_ called at <blahblah>/Cycle.pm line 106. This is because _get_type only handles ( SCALAR REF ARRAY HASH CODE ), and anything else will fall though, which causes _find_cycle_dispatch to give this obscure error. So GLOB (and perhaps LVALUE?) are not handled properly. And the error handling is not quite right. This is Devel-Cycle 1.09 (the latest) on perl 5.8.8 on x86-64. -- greg

Tue Jul 08 10:57:52 2008 SREZIC [...] cpan.org - Correspondence added

On Mon May 12 18:39:58 2008, greg@blekko.com wrote: Show quoted text

> Devel::Cycle doesn't handle type GLOB. In fact it gives an obscure > error when you hand it something with a GLOB: > > Undefined subroutine &Devel::Cycle::_find_cycle_ called at > <blahblah>/Cycle.pm line 106. > > This is because _get_type only handles ( SCALAR REF ARRAY HASH CODE ), > and anything else will fall though, which causes _find_cycle_dispatch > to give this obscure error. > > So GLOB (and perhaps LVALUE?) are not handled properly. And the error > handling is not quite right. > > This is Devel-Cycle 1.09 (the latest) on perl 5.8.8 on x86-64. >

I made a patch publicly available workarounding the problem by just skipping unhandled types. See http://ftp.funet.fi/pub/CPAN/authors/id/S/SR/SREZIC/patches/Devel-Cycle-1.09-SREZIC-01.patch Regards, Slaven

Tue Jul 08 10:57:57 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 08 20:52:33 2008 greg [...] blekko.com - Correspondence added

Subject:	Re: [rt.cpan.org #35825] Bug in handling GLOBs
Date:	Tue, 8 Jul 2008 17:52:04 -0700
To:	Slaven_Rezic via RT <bug-Devel-Cycle [...] rt.cpan.org>
From:	Greg Lindahl <greg [...] blekko.com>

On Tue, Jul 08, 2008 at 10:57:58AM -0400, Slaven_Rezic via RT wrote: Show quoted text

> I made a patch publicly available workarounding the problem by just > skipping unhandled types. See > http://ftp.funet.fi/pub/CPAN/authors/id/S/SR/SREZIC/patches/Devel-Cycle-1.09-SREZIC-01.patch

Thanks! -- greg

Tue Jul 08 21:24:17 2008 lincoln.stein [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #35825] Bug in handling GLOBs
Date:	Tue, 8 Jul 2008 21:24:04 -0400
To:	bug-Devel-Cycle [...] rt.cpan.org
From:	"Lincoln Stein" <lincoln.stein [...] gmail.com>

Much obliged. On Tue, Jul 8, 2008 at 8:52 PM, Greg Lindahl via RT < bug-Devel-Cycle@rt.cpan.org> wrote: Show quoted text

> Queue: Devel-Cycle > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35825 > > > On Tue, Jul 08, 2008 at 10:57:58AM -0400, Slaven_Rezic via RT wrote: >

> > I made a patch publicly available workarounding the problem by just > > skipping unhandled types. See > >

> http://ftp.funet.fi/pub/CPAN/authors/id/S/SR/SREZIC/patches/Devel-Cycle-1.09-SREZIC-01.patch > > Thanks! > > -- greg > > >

-- Lincoln D. Stein Ontario Institute for Cancer Research 101 College St., Suite 800 Toronto, ON, Canada M5G0A3 416 673-8514 Assistant: Stacey Fairfield <Stacey.Fairfield@oicr.on.ca> Cold Spring Harbor Laboratory 1 Bungtown Road Cold Spring Harbor, NY 11724 USA (516) 367-8380 Assistant: Sandra Michelsen <michelse@cshl.edu>

Tue Jul 08 21:29:17 2008 LDS [...] cpan.org - Correspondence added

Thanks for the patch! It is in version 1.10.

Tue Jul 08 21:29:18 2008 LDS [...] cpan.org - Status changed from 'open' to 'resolved'