| Subject: | Pod::Simple fails "make test" due to non-localised $1 being passed to File::Spec->catfile() |
Hi,
Pod::Simple 3.05 fails make test for "t/htmlbat.t" on some Windows
platforms with the following error:
http://www.nntp.perl.org/group/perl.cpan.testers/2008/03/msg1135946.html
This is caused by an non-localised $1 being passed to
File::Spec->catfile() in two places in Pod::Simple::HTMLBatch.pm.
Attached is a patch to fix it.
John.
--
| Subject: | Pod_Simple_3_05_localise.patch |
--- C:\Temp\Pod-Simple-3.05\lib\Pod\Simple\HTMLBatch.pm Sat Jul 8 00:40:10 2006 UTC
+++ C:\Temp\Pod-Simple-3.05_patch\lib\Pod\Simple\HTMLBatch.pm Sun May 11 13:43:51 2008 UTC
@@ -607,7 +607,8 @@
my $url = $chunk->[0];
my $outfile;
if( ref($chunk->[-1]) and $url =~ m{^(_[-a-z0-9_]+\.css$)} ) {
- $outfile = $self->filespecsys->catfile( $outdir, $1 );
+ my $css_file = $1;
+ $outfile = $self->filespecsys->catfile( $outdir, $css_file );
DEBUG > 5 and print "Noting $$chunk[0] as a file I'll create.\n";
} else {
DEBUG > 5 and print "OK, noting $$chunk[0] as an external CSS.\n";
@@ -772,7 +773,8 @@
my $outfile;
if( ref($script->[-1]) and $url =~ m{^(_[-a-z0-9_]+\.js$)} ) {
- $outfile = $self->filespecsys->catfile( $outdir, $1 );
+ my $js_file = $1;
+ $outfile = $self->filespecsys->catfile( $outdir, $js_file );
DEBUG > 5 and print "Noting $$script[0] as a file I'll create.\n";
} else {
DEBUG > 5 and print "OK, noting $$script[0] as an external JavaScript.\n";