Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 35774
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: PJF [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.082
Fixed in: (no value)

History Show all quoted text
  Sun May 11 11:23:03 2008 PJF [...] cpan.org - Ticket created
Subject: InputOutput::RequireBriefOpen wants STDIN,STDOUT,STDERR to be closed as soon as possible
G'day wonderful Perl::Critic maintainers, Today I discovered that InputOutput::RequireBriefOpen believes that the special filehandles STDIN, STDOUT and STDERR should be closed as soon as possible after opening. That doesn't seem right, since these filehandles may be redirected for a number of reasons, such as writing errors to a custom logfile[1]: open(STDERR,'>>','/var/log/my-errors.log'); I believe it should be possible to redirect these standard filehandles without triggering this rule. Cheerio, Paul [1] Or in my case, dark and terrible magics to implement a multi-argument, shell-bypassing equivalent of backticks for Win32 systems in IPC::System::Simple.
  Sun May 11 12:07:38 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #35774] InputOutput::RequireBriefOpen wants STDIN,STDOUT,STDERR to be closed as soon as possible
Date: Sun, 11 May 2008 11:07:24 -0500
To: bug-Perl-Critic [...] rt.cpan.org, perlcritic <dev [...] perlcritic.tigris.org>
From: Elliot Shank <perl [...] galumph.com>
PJF via RT wrote: Show quoted text
> Sun May 11 11:23:03 2008: Request 35774 was acted upon. > Transaction: Ticket created by PJF > Queue: Perl-Critic > Subject: InputOutput::RequireBriefOpen wants STDIN,STDOUT,STDERR to be > closed as soon as possible > Broken in: 1.082 > Severity: Normal > Owner: Nobody > Requestors: PJF@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35774 > > > > G'day wonderful Perl::Critic maintainers, > > Today I discovered that InputOutput::RequireBriefOpen believes that the > special filehandles STDIN, STDOUT and STDERR should be closed as soon as > possible after opening. That doesn't seem right, since these > filehandles may be redirected for a number of reasons, such as writing > errors to a custom logfile[1]: > > open(STDERR,'>>','/var/log/my-errors.log'); > > I believe it should be possible to redirect these standard filehandles > without triggering this rule.
Show quoted text
> [1] Or in my case, dark and terrible magics to implement a > multi-argument, shell-bypassing equivalent of backticks for Win32 > systems in IPC::System::Simple.
Seems reasonable to me, but I'd like to hear comments from the others before I do anything about it.
  Sun May 11 12:07:40 2008 The RT System itself - Status changed from 'new' to 'open'
  Sun May 11 16:23:53 2008 chris [...] equilibrious.net - Correspondence added
CC: bug-Perl-Critic [...] rt.cpan.org
Subject: Re: [rt.cpan.org #35774] InputOutput::RequireBriefOpen wants STDIN,STDOUT,STDERR to be closed as soon as possible
Date: Sun, 11 May 2008 15:23:19 -0500
To: dev [...] perlcritic.tigris.org
From: Chris Dolan <chris [...] equilibrious.net>
On May 11, 2008, at 11:07 AM, Elliot Shank wrote: Show quoted text
> PJF via RT wrote:
>> Sun May 11 11:23:03 2008: Request 35774 was acted upon. >> Transaction: Ticket created by PJF >> Queue: Perl-Critic >> Subject: InputOutput::RequireBriefOpen wants >> STDIN,STDOUT,STDERR to be >> closed as soon as possible >> Broken in: 1.082 >> Severity: Normal >> Owner: Nobody >> Requestors: PJF@cpan.org >> Status: new >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35774 > >> G'day wonderful Perl::Critic maintainers, >> Today I discovered that InputOutput::RequireBriefOpen believes >> that the >> special filehandles STDIN, STDOUT and STDERR should be closed as >> soon as >> possible after opening. That doesn't seem right, since these >> filehandles may be redirected for a number of reasons, such as >> writing >> errors to a custom logfile[1]: >> open(STDERR,'>>','/var/log/my-errors.log'); >> I believe it should be possible to redirect these standard >> filehandles >> without triggering this rule.
>
>> [1] Or in my case, dark and terrible magics to implement a >> multi-argument, shell-bypassing equivalent of backticks for Win32 >> systems in IPC::System::Simple.
> > Seems reasonable to me, but I'd like to hear comments from the > others before I do anything about it.
Seems quite reasonable to me too. Chris
  Sun May 11 18:46:04 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #35774] InputOutput::RequireBriefOpen wants STDIN,STDOUT,STDERR to be closed as soon as possible
Date: Sun, 11 May 2008 17:45:51 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Show quoted text
>> Today I discovered that InputOutput::RequireBriefOpen believes that >> the special filehandles STDIN, STDOUT and STDERR should be closed >> as soon as possible after opening. That doesn't seem right, since >> these filehandles may be redirected for a number of reasons, such >> as writing errors to a custom logfile[1]:
> > Seems reasonable to me, but I'd like to hear comments from the others > before I do anything about it.
Change checked in. Will be in the next release.
  Sat May 24 16:18:36 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #35774] InputOutput::RequireBriefOpen wants STDIN,STDOUT,STDERR to be closed as soon as possible
Date: Sat, 24 May 2008 15:18:20 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Released in 1.084 today.
  Tue May 27 12:56:56 2008 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'