Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 35752
Status: resolved
Priority: 0/
Queue: Net-DNS
People
Owner: Nobody in particular
Requestors: tcallawa [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.63
Fixed in: (no value)
Attachments
perl-Net-DNS-bz437681.patch
PGP.sig

History Show all quoted text
  Fri May 09 13:02:48 2008 tcallawa [...] redhat.com - Ticket created
Subject: perl-5.10.0 + Net::DNS equals lots of noise to console
With perl 5.10.0, Net::DNS generates a significant amount of noise, specifically: Constant subroutine Net::DNS::Resolver::Base::AF_INET6 redefined at /usr/lib/perl5/5.10.0/Exporter.pm line 66. at /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/Resolver/Base.pm line 65 Prototype mismatch: sub Net::DNS::Resolver::Base::AF_INET6 () vs none at /usr/lib/perl5/5.10.0/Exporter.pm line 66. at /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/Resolver/Base.pm line 65 Constant subroutine Net::DNS::Resolver::Base::PF_INET6 redefined at /usr/lib/perl5/5.10.0/Exporter.pm line 66. at /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/Resolver/Base.pm line 65 Prototype mismatch: sub Net::DNS::Resolver::Base::PF_INET6 () vs none at /usr/lib/perl5/5.10.0/Exporter.pm line 66. at /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/Resolver/Base.pm line 65 This was causing serious pain in applications like mrtg and spamassassin, which were logging this information repeatedly. I generated a patch which seemed to resolve the issue for Net::DNS, but seems to be causing a new bug (https://bugzilla.redhat.com/show_bug.cgi?id=445314). I've attached my original fix, but it probably needs some work.
  Fri May 09 13:04:03 2008 tcallawa [...] redhat.com - Correspondence added
From: tcallawa [...] redhat.com
Show quoted text
> I generated a patch which seemed to resolve the issue for Net::DNS, > but seems to be causing a new bug > (https://bugzilla.redhat.com/show_bug.cgi?id=445314). I've attached my > original fix, but it probably needs some work.
This is the patch I came up with that seemed to resolve the issue.
diff -up Net-DNS-0.63/lib/Net/DNS/Resolver/Base.pm.BAD Net-DNS-0.63/lib/Net/DNS/Resolver/Base.pm --- Net-DNS-0.63/lib/Net/DNS/Resolver/Base.pm.BAD 2008-04-09 10:19:50.000000000 -0400 +++ Net-DNS-0.63/lib/Net/DNS/Resolver/Base.pm 2008-04-09 10:20:15.000000000 -0400 @@ -62,7 +62,7 @@ BEGIN { # INET6 prior to 2.01 will not work; sorry. eval {require IO::Socket::INET6; IO::Socket::INET6->VERSION("2.00");} ) { - import Socket6; + Socket6->import(qw(getaddrinfo)); $has_inet6=1; }else{ $has_inet6=0; diff -up Net-DNS-0.63/lib/Net/DNS/Nameserver.pm.BAD Net-DNS-0.63/lib/Net/DNS/Nameserver.pm --- Net-DNS-0.63/lib/Net/DNS/Nameserver.pm.BAD 2008-04-09 10:23:49.000000000 -0400 +++ Net-DNS-0.63/lib/Net/DNS/Nameserver.pm 2008-04-09 10:31:14.000000000 -0400 @@ -33,7 +33,7 @@ BEGIN { } elsif ( eval {require Socket6;} && # INET6 earlier than V2.01 will not work; sorry. eval {require IO::Socket::INET6; IO::Socket::INET6->VERSION("2.01");} ) { - import Socket6; + import IO::Socket::INET6; $has_inet6 = 1; } else { $has_inet6=0;
  Fri May 09 17:47:59 2008 olaf [...] dacht.net - Correspondence added
Subject: Re: [rt.cpan.org #35752] perl-5.10.0 + Net::DNS equals lots of noise to console
Date: Fri, 9 May 2008 23:47:38 +0200
To: bug-Net-DNS [...] rt.cpan.org
From: Olaf Kolkman <olaf [...] dacht.net>
I see a redhat.com address in the header and had recent reports that the version on redhat was slightly modified wrt the CPAN version namely that in Net/DNS/Resolver/Base.pm import Socket6; being replaced by Socket6->import(qw(getaddrinfo)); Would you be so kind to double check that these errors occur with the native CPAN version or are the cause of the redhat specific patch? --Olaf On May 9, 2008, at 7:02 PM, tcallawa@redhat.com via RT wrote: Show quoted text
> > Fri May 09 13:02:48 2008: Request 35752 was acted upon. > Transaction: Ticket created by tcallawa@redhat.com > Queue: Net-DNS > Subject: perl-5.10.0 + Net::DNS equals lots of noise to console > Broken in: 0.63 > Severity: Important > Owner: Nobody > Requestors: tcallawa@redhat.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35752 > > > > With perl 5.10.0, Net::DNS generates a significant amount of noise, > specifically: > > Constant subroutine Net::DNS::Resolver::Base::AF_INET6 redefined at > /usr/lib/perl5/5.10.0/Exporter.pm line 66. > at > /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/ > Resolver/Base.pm > line 65 > Prototype mismatch: sub Net::DNS::Resolver::Base::AF_INET6 () vs > none at > /usr/lib/perl5/5.10.0/Exporter.pm line 66. > at > /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/ > Resolver/Base.pm > line 65 > Constant subroutine Net::DNS::Resolver::Base::PF_INET6 redefined at > /usr/lib/perl5/5.10.0/Exporter.pm line 66. > at > /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/ > Resolver/Base.pm > line 65 > Prototype mismatch: sub Net::DNS::Resolver::Base::PF_INET6 () vs > none at > /usr/lib/perl5/5.10.0/Exporter.pm line 66. > at > /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Net/DNS/ > Resolver/Base.pm > line 65 > > This was causing serious pain in applications like mrtg and > spamassassin, which were logging this information repeatedly. > > I generated a patch which seemed to resolve the issue for Net::DNS, > but > seems to be causing a new bug > (https://bugzilla.redhat.com/show_bug.cgi?id=445314). I've attached my > original fix, but it probably needs some work.
Download PGP.sig
application/pgp-signature 235b

Message body not shown because it is not plain text.

  Fri May 09 17:48:02 2008 The RT System itself - Status changed from 'new' to 'open'
  Fri May 09 18:48:51 2008 tcallawa [...] redhat.com - Correspondence added
From: tcallawa [...] redhat.com
On Fri May 09 17:47:59 2008, olaf@dacht.net wrote: Show quoted text
> > > I see a redhat.com address in the header and had recent reports that > the version on redhat was slightly modified wrt the CPAN version > namely that in Net/DNS/Resolver/Base.pm > import Socket6; > being replaced by > Socket6->import(qw(getaddrinfo)); > > Would you be so kind to double check that these errors occur with the > native CPAN version or are the cause of the redhat specific patch?
The errors occur with the native CPAN version. The patch was designed specifically to resolve the errors, but it seems incomplete/incorrect as other errors (unrelated to the errors described in this bug) are caused by applying it.
  Sat May 10 05:29:19 2008 olaf [...] dacht.net - Correspondence added
Subject: Re: [rt.cpan.org #35752] perl-5.10.0 + Net::DNS equals lots of noise to console
Date: Sat, 10 May 2008 11:28:36 +0200
To: bug-Net-DNS [...] rt.cpan.org
From: Olaf Kolkman <olaf [...] dacht.net>
On my development system it turns out that I have a different set of errors with perl5.10. These have to do with Dynaloader complaining about the bootstrap method. I've gotten rid of those by using XSloader and allowing Dynaloader for backwards compability. Maybe this is interrelated. Could you first apply the following patch and then see what happens? --Olaf --- lib/Net/DNS.pm (revision 718) +++ lib/Net/DNS.pm (working copy) @@ -38,9 +38,9 @@ BEGIN { - require DynaLoader; + require Exporter; - @ISA = qw(Exporter DynaLoader); + @ISA = qw(Exporter ); # these need to live here because of dependencies further on. @EXPORT = qw(mx yxrrset nxrrset yxdomain nxdomain rr_add rr_del); @EXPORT_OK= qw(name2labels wire2presentation rrsort stripdot); @@ -51,9 +51,25 @@ $VERSION = '0.63'; $SVNVERSION = (qw$LastChangedRevision$)[1]; + + + $HAVE_XS = eval { local $SIG{'__DIE__'} = 'DEFAULT'; - __PACKAGE__->bootstrap(); 1 + + + eval { + require XSLoader; + XSLoader::load('Net::DNS', $VERSION); + 1; + } or do { + + require DynaLoader; + push @ISA, 'DynaLoader'; + bootstrap Net::DNS $VERSION; + 1; + }; + } ? 1 : 0; }
Download PGP.sig
application/pgp-signature 235b

Message body not shown because it is not plain text.

  Mon May 12 04:58:32 2008 mmaslano [...] redhat.com - Correspondence added
From: mmaslano [...] redhat.com
This patch fixed all issues. Thank you for your quick reply, I'll update Net::DNS with this patch immediately. On Sat May 10 05:29:19 2008, olaf@dacht.net wrote: Show quoted text
> > On my development system it turns out that I have a different set of > errors with perl5.10. These have to do with Dynaloader complaining > about the bootstrap method. I've gotten rid of those by using XSloader > and allowing Dynaloader for backwards compability. Maybe this is > interrelated. > > Could you first apply the following patch and then see what happens? > > --Olaf > > --- lib/Net/DNS.pm (revision 718) > +++ lib/Net/DNS.pm (working copy) > @@ -38,9 +38,9 @@ > > > BEGIN { > - require DynaLoader; > + > require Exporter; > - @ISA = qw(Exporter DynaLoader); > + @ISA = qw(Exporter ); > # these need to live here because of dependencies further on. > @EXPORT = qw(mx yxrrset nxrrset yxdomain nxdomain rr_add rr_del); > @EXPORT_OK= qw(name2labels wire2presentation rrsort stripdot); > @@ -51,9 +51,25 @@ > $VERSION = '0.63'; > $SVNVERSION = (qw$LastChangedRevision$)[1]; > > + > + > + > $HAVE_XS = eval { > local $SIG{'__DIE__'} = 'DEFAULT'; > - __PACKAGE__->bootstrap(); 1 > + > + > + eval { > + require XSLoader; > + XSLoader::load('Net::DNS', $VERSION); > + 1; > + } or do { > + > + require DynaLoader; > + push @ISA, 'DynaLoader'; > + bootstrap Net::DNS $VERSION; > + 1; > + }; > + > } ? 1 : 0; > > } >
  Mon May 12 14:33:41 2008 olaf [...] dacht.net - Correspondence added
Subject: Re: [rt.cpan.org #35752] perl-5.10.0 + Net::DNS equals lots of noise to console
Date: Mon, 12 May 2008 20:33:08 +0200
To: bug-Net-DNS [...] rt.cpan.org
From: Olaf Kolkman <olaf [...] dacht.net>
On May 12, 2008, at 10:58 AM, Marcela Maslanova via RT wrote: Show quoted text
> > Queue: Net-DNS > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35752 > > > This patch fixed all issues. > > Thank you for your quick reply, I'll update Net::DNS with this patch > immediately.
It may not solve all problems cross-platform. More testing is needed. Specifically with old versions of perl. --Olaf
Download PGP.sig
application/pgp-signature 235b

Message body not shown because it is not plain text.

  Mon May 12 14:39:36 2008 tcallawa [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #35752] perl-5.10.0 + Net::DNS equals lots of noise to console
Date: Mon, 12 May 2008 14:39:04 -0400
To: bug-Net-DNS [...] rt.cpan.org
From: "Tom \"spot\" Callaway" <tcallawa [...] redhat.com>
On Mon, 2008-05-12 at 14:33 -0400, Olaf M. Kolkman via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=35752 > > > > On May 12, 2008, at 10:58 AM, Marcela Maslanova via RT wrote: >
> > > > Queue: Net-DNS > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35752 > > > > > This patch fixed all issues. > > > > Thank you for your quick reply, I'll update Net::DNS with this patch > > immediately.
> > > It may not solve all problems cross-platform. More testing is needed. > Specifically with old versions of perl.
Sure, but its a lot better than the old patch. :) ~spot
  Tue Dec 16 16:48:37 2008 OLAF [...] cpan.org - Correspondence added
Closing an old thread
  Tue Dec 16 16:48:38 2008 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Dec 16 16:48:38 2008 OLAF [...] cpan.org - Correspondence added
Closing an old thread
  Tue Dec 16 16:48:38 2008 The RT System itself - Status changed from 'resolved' to 'open'
  Tue Dec 16 16:48:39 2008 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'