Skip Menu |

This queue is for tickets about the Business-Barcode-EAN13 CPAN distribution.

Report information
The Basics
Id: 35576
Status: new
Priority: 0/
Queue: Business-Barcode-EAN13

People
Owner: Nobody in particular
Requestors: hugues [...] amazon.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Warning in valid_barcode
Date: Fri, 2 May 2008 01:19:46 -0700 (PDT)
To: bug-Business-Barcode-EAN13 [...] rt.cpan.org
From: hugues [...] amazon.com (Hugues Andreux)
Hi, Would it be possible to have '==' changed with 'eq' in valid_barcode, as in the patch below? Using '==' is causing warnings with -w when the check digit is, in fact, not a digit... Thanks, Hugues Andreux --- EAN13.pm.orig 2008-05-02 00:56:27.000000000 -0700 +++ EAN13.pm 2008-05-02 00:57:45.000000000 -0700 @@ -107,7 +107,7 @@ my $bcode = shift; my $check_digit = chop($bcode); return 0 unless _valid_stem($bcode); - return ($check_digit == _check_digit($bcode)); + return ($check_digit eq _check_digit($bcode)); } sub _valid_stem {