Skip Menu |

This queue is for tickets about the Imager CPAN distribution.

Report information
The Basics
Id: 35568
Status: resolved
Priority: 0/
Queue: Imager

People
Owner: TONYC [...] cpan.org
Requestors: andrej.czapszys [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.58
  • 0.59
  • 0.60
  • 0.61
  • 0.62
  • 0.63
  • 0.64
Fixed in: (no value)



Subject: Gif canvas/screen size is wrong
When writing gifs, the screen height is used as the screen width, if the gif_screen_height tag exists. Patch attached.
Subject: Imager-fix-gif-canvas.diff
diff -ru Imager-0.64.orig/gif.c Imager-0.64.new/gif.c --- Imager-0.64.orig/gif.c 2007-11-03 16:24:22.000000000 -0700 +++ Imager-0.64.new/gif.c 2008-05-01 09:21:14.000000000 -0700 @@ -1733,8 +1733,8 @@ if (!i_tags_get_int(&imgs[0]->tags, "gif_screen_width", 0, &scrw)) scrw = 0; - if (!i_tags_get_int(&imgs[0]->tags, "gif_screen_height", 0, &scrw)) - scrw = 0; + if (!i_tags_get_int(&imgs[0]->tags, "gif_screen_height", 0, &scrh)) + scrh = 0; anylocal = 0; localmaps = i_mempool_alloc(&mp, sizeof(int) * count);
On Thu May 01 12:28:47 2008, axc wrote: Show quoted text
> When writing gifs, the screen height is used as the screen width, if the > gif_screen_height tag exists. > Patch attached.
Thanks, this is fixed in svn for the next release. I've also added tests to check for this and some other screen related issues.
On Thu May 01 12:28:47 2008, axc wrote: Show quoted text
> When writing gifs, the screen height is used as the screen width, if the > gif_screen_height tag exists. > Patch attached.
Fixed in Imager 0.65, released last night.