Skip Menu |

This queue is for tickets about the Encode-Detect CPAN distribution.

Report information
The Basics
Id: 35564
Status: resolved
Priority: 0/
Queue: Encode-Detect
People
Owner: JGMYERS [...] cpan.org
Requestors: dmuey [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu May 01 09:07:48 2008 dmuey [...] cpan.org - Ticket created
Subject: HASATTRIBUTE_UNUSED makes gcc-3.3 unable to install
Detector.xs suffers from this compiler issue: http://rt.perl.org/rt3//Public/Bug/Display.html?id=39634 The attached patch allows it to work for everybody. This is a sample of the error received: Show quoted text
> error building lib/Encode/Detect/Detector.o from 'lib/Encode/Detect/ > Detector.c' at /usr/lib/perl5/site_perl/5.8.8/ExtUtils/CBuilder/ > Base.pm line 109. > make: *** [all] Error 2 > JGMYERS/Encode-Detect-1.00.tar.gz > /usr/bin/make -- NOT OK > Running make install > Make had returned bad status, install seems impossible > perlmod--Install done
Subject: rt.39634.diff
--- Detector.xs.orig 2008-05-01 07:59:58.000000000 -0500 +++ Detector.xs 2008-05-01 08:00:28.000000000 -0500 @@ -38,6 +38,7 @@ #define PERL_NO_GET_CONTEXT /* we want efficiency */ #include "EXTERN.h" #include "perl.h" +#undef HASATTRIBUTE_UNUSED #include "XSUB.h" }
  Thu May 01 12:57:00 2008 JGMYERS [...] cpan.org - Correspondence added
From: JGMYERS [...] cpan.org
That proposed fix is a bit too broad. How about the one attached here?
--- Encode-Detect-1.00/Detector.xs 2006-06-26 15:06:13.000000000 -0700 +++ Encode-Detect-1.01/Detector.xs 2008-05-01 09:53:13.000000000 -0700 @@ -38,6 +38,12 @@ #define PERL_NO_GET_CONTEXT /* we want efficiency */ #include "EXTERN.h" #include "perl.h" + +// work around perlbug #39634 +#if __GNUC__ == 3 && __GNUC_MINOR__ <= 3 +#undef HASATTRIBUTE_UNUSED +#endif + #include "XSUB.h" }
  Thu May 01 12:57:03 2008 The RT System itself - Status changed from 'new' to 'open'
  Tue May 06 10:52:48 2008 dmuey [...] cpan.org - Correspondence added
From: dmuey [...] cpan.org
On Thu May 01 12:57:00 2008, JGMYERS wrote: Show quoted text
> That proposed fix is a bit too broad. How about the one attached here?
I believe that should do it, trying to find an effected box to test it on now...
  Tue May 27 15:15:04 2008 card [...] genesisnetsolutions.com - Correspondence added
From: card [...] genesisnetsolutions.com
The proposed fix worked for me. Mike
  Tue May 27 16:56:11 2008 JGMYERS [...] cpan.org - Correspondence added
Resolved in version 1.01
  Tue May 27 16:56:14 2008 JGMYERS [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue May 27 16:56:21 2008 JGMYERS [...] cpan.org - Given to JGMYERS