Skip Menu |

This queue is for tickets about the Win32API-Registry CPAN distribution.

Report information
The Basics
Id: 35390
Status: resolved
Priority: 0/
Queue: Win32API-Registry

People
Owner: Nobody in particular
Requestors: JDB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: Win64 compatibility
The attached patch updates the typemap to use the correct Perl casting macros INT2PTR() and PTR2IV() to convert between pointers and integers, which reduce compiler warnings when sizeof(IV) is larger than sizeof(void*). There are also several changes to the regression tests: * Set the correct test count. * Don't just omit the skipped test (27) altogether, you still need to print an "ok 27" line, or renumber the remaining tests. * Fix tests for Win64: the VALENT structure uses 8 byte alignment on Win64, so the arguments to pack() need to be adjusted accordingly. In general it would be a good idea to move test.pl to t/test.t so that MakeMaker will run it via Test::Harness. That would have detected the wrong test count, and the missing test output for #27 automatically. If you do that, then I would recommend to also change all the warn() calls to normals print()s, get rid of $Debug and let Test::Harness control if you get verbose output or not.
Subject: Win32API-Registry.diff.gz
Download Win32API-Registry.diff.gz
application/gzip 1.3k

Message body not shown because it is not plain text.

Patch was applied and tests run. Released in 0.30. Thank you JDB.