Bug #35357 for File-Copy-Recursive: Error 'closedir() attempted on invalid dirhandle PTH_DH' when deleting empty directory

Thanks, for the reply, I look forward to your next version. FCR has been a huge help in some tools I wrote for work. I can't remember if I ever sent this to you, so apologies if it's a duplicate. I added an extra feature to fcopy that lets you set a flag to only copy files that are newer at the source than the ones at the destination. For my particular application, the cost of the stats was a lot less than copying a ton of files that hadn't changed. Attached is a diff patch against 0.36 of Recursive.pm. Thanks, Drew -- Drew Marold - Drew@marold.org Perl programmer, bass player, luthier, Gentleman Adventurer Photography: http://www.flickr.com/photos/unstoppabledrew/ Nothing looks worse on your outdoors resume than a list of the possible locations of your remains.

17c17 < $CondCopy $BdTrgWrn $SkipFlop --- > $CondCopy $BdTrgWrn $SkipFlop $NewOnly 38a39 > $NewOnly = 0; 75a77,95 > my $newercheck = sub { > my ($src, $dst) = @_; > # Normalize slashes > $src =~ tr|\\|/|; > $dst =~ tr|\\|/|; > # if destination is a directory, tack on filename for doing stat > chop $dst if $dst =~ m|.*/$|; > my $srclast = (split m|/|, $src)[-1]; > my $dstlast = (split m|/|, $dst)[-1]; > if ( $srclast ne $dstlast ) > { $dst = join '/', ($dst, $srclast); } > return 1 unless ( -f $dst ); # Not there ? Copy it > if ( (stat $src)[9] <= (stat $dst)[9] ) > { > return 0; #don't copy, dest is newer > } > return 1; > }; > 113a134,137 > if( $NewOnly and ! $newercheck->(@_) ) > { > return wantarray ? (1,0,0) : 1; > }