Skip Menu |

This queue is for tickets about the DBIx-Class-UUIDColumns CPAN distribution.

Report information
The Basics
Id: 35266
Status: resolved
Priority: 0/
Queue: DBIx-Class-UUIDColumns

People
Owner: claco [...] cpan.org
Requestors: djh [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.02003
Fixed in: (no value)



Subject: installs failed

Message body is not shown because it is too large.

CC: dbix-class [...] lists.rawmode.org
Subject: Re: [rt.cpan.org #35266] installs failed
Date: Mon, 21 Apr 2008 12:53:16 -0400
To: bug-DBIx-Class-UUIDColumns [...] rt.cpan.org
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Dave Howorth via RT wrote: Show quoted text
> Mon Apr 21 12:19:24 2008: Request 35266 was acted upon. > Transaction: Ticket created by DJH > Queue: DBIx-Class-UUIDColumns > Subject: installs failed > Broken in: 0.02003 > Severity: Important > Owner: Nobody > Requestors: djh@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35266 > > > > I just tried to install the module on two machines. Both failed, with > apparently different faults: > > ======= > m/c 1 : > ======= > > There appears to be an undeclared dependency on a particular version of > SQL::Translator: >
[snip] Show quoted text
> t/uuid.............DBIx::Class::Schema::deploy(): Can't deploy without > SQL::Translator 0.08: 'SQL::Translator version 0.08 required--this is > only version 0.07 at (eval 164) line 2. > BEGIN failed--compilation aborted at (eval 164) line 2. > ' at t/lib/DBIC/Test.pm line 66 > # No tests run! > t/uuid.............dubious > Test returned status 255 (wstat 65280, 0xff00) > DIED. FAILED tests 1-13 > Failed 13/13 tests, 0.00% okay
Thank you for filing a bug report. Please see this link for history on the matter: http://www.mail-archive.com/dbix-class@lists.rawmode.org/msg03700.html I declare this NMB: Not My Bug. DBIC deploy() is bailing on a version requirement not listed in its Makefile.PL, thus making installation of any dist that uses deploy() for its tests impossible. I see this same failure message on the DigestColumns dist as well. Of course, we can: - put SQL::T 0.08 in my dists Makefile.PL PREREQ...but it's not my requirement - put SQL::T 0.08 in the code that checks to see if SQL::T is available in my dists test class...but I would have to update that everytime DBIC decides it needs a newer version (and doesn't declare it in it's prereq) - punt and say upgrade to SQL::T 0.08 and ask again o nthe DBIC list on what to really do about this For now I choose the latter. :-) -=Chris
Download signature.asc
application/pgp-signature 187b

Message body not shown because it is not plain text.

From: djh [...] cpan.org
On Mon Apr 21 12:54:02 2008, claco@chrislaco.com wrote: Show quoted text
> I declare this NMB: Not My Bug.
Hmm. I don't get an error when I install or use DBIC and I don't see this reported as a bug against DBIC. I just report what I see, which is that this module's installation fails. Sorry, the last thing punters want or need is bickering between 'friendly' module authors. It's a great way to drive users away. BTW, the other machine failed with a different fault. I haven't had time to investigate that any further yet. Cheers, Dave
Subject: Re: [rt.cpan.org #35266] installs failed
Date: Mon, 21 Apr 2008 16:52:50 -0400
To: bug-DBIx-Class-UUIDColumns [...] rt.cpan.org
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Dave Howorth via RT wrote: Show quoted text
> Queue: DBIx-Class-UUIDColumns > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35266 > > > On Mon Apr 21 12:54:02 2008, claco@chrislaco.com wrote:
>> I declare this NMB: Not My Bug.
> > Hmm. I don't get an error when I install or use DBIC and I don't see > this reported as a bug against DBIC. I just report what I see, which is > that this module's installation fails.
It's only a bug in the sense that DBIC because DBIC doesn't list it a a prereq, yet part of it's functionality (deploy in this case) won't work without the newer 0.08 version of SQL::Translator. I started the thread listed, and apparently I need to start it again. :-) Show quoted text
> > Sorry, the last thing punters want or need is bickering between > 'friendly' module authors. It's a great way to drive users away.
I never bicker with Matt (DBIC). He always wins. :-) Show quoted text
> > BTW, the other machine failed with a different fault. I haven't had time > to investigate that any further yet. > > Cheers, Dave > >
The other one is just me being stupid. I thought I fixed this. Apparently not: Cannot determine source for t/*/*.t at Some make test versions fail for test patterns on directories that don't exist. Some don't. Go figure. It's a good exist to revisit this again, and maybe I'll just plop out a new version since the important part is getting one out that works, rather than pointing the finger at another dist. :-) -=Chris
Download signature.asc
application/pgp-signature 187b

Message body not shown because it is not plain text.

CC: bug-DBIx-Class-UUIDColumns [...] rt.cpan.org, dbix-class [...] lists.rawmode.org
Subject: Re: [Dbix-class] Re: [rt.cpan.org #35266] installs failed
Date: Tue, 22 Apr 2008 14:04:03 +0100
To: claco [...] chrislaco.com, "DBIx::Class user and developer list" <dbix-class [...] lists.scsys.co.uk>
From: Matt S Trout <dbix-class [...] trout.me.uk>
On Mon, Apr 21, 2008 at 12:53:16PM -0400, Christopher H. Laco wrote: Show quoted text
> Dave Howorth via RT wrote:
> >Mon Apr 21 12:19:24 2008: Request 35266 was acted upon. > >Transaction: Ticket created by DJH > > Queue: DBIx-Class-UUIDColumns > > Subject: installs failed > > Broken in: 0.02003 > > Severity: Important > > Owner: Nobody > > Requestors: djh@cpan.org > > Status: new > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35266 > > > > > > >I just tried to install the module on two machines. Both failed, with > >apparently different faults: > > > >======= > >m/c 1 : > >======= > > > >There appears to be an undeclared dependency on a particular version of > >SQL::Translator: > >
> > [snip] >
> >t/uuid.............DBIx::Class::Schema::deploy(): Can't deploy without > >SQL::Translator 0.08: 'SQL::Translator version 0.08 required--this is > >only version 0.07 at (eval 164) line 2. > >BEGIN failed--compilation aborted at (eval 164) line 2. > >' at t/lib/DBIC/Test.pm line 66 > ># No tests run! > >t/uuid.............dubious > > Test returned status 255 (wstat 65280, 0xff00) > >DIED. FAILED tests 1-13 > > Failed 13/13 tests, 0.00% okay
> > Thank you for filing a bug report. Please see this link for history on > the matter: > > http://www.mail-archive.com/dbix-class@lists.rawmode.org/msg03700.html > > I declare this NMB: Not My Bug. DBIC deploy() is bailing on a version > requirement not listed in its Makefile.PL, thus making installation of > any dist that uses deploy() for its tests impossible. I see this same > failure message on the DigestColumns dist as well.
This -is- your bug. the DBIx::Class tests themselves run fine without SQL::Translator because they provide a DDL file; deploy() only needs SQLT on the *build* side to generate that file originally, which is why it's not marked as a dependency on the DBIx::Class dist itself. Please fix UUIDColumns' tests. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/
CC: DBIx::Class user and developer list <dbix-class [...] lists.scsys.co.uk>, bug-DBIx-Class-UUIDColumns [...] rt.cpan.org, dbix-class [...] lists.rawmode.org
Subject: Re: [Dbix-class] Re: [rt.cpan.org #35266] installs failed
Date: Tue, 22 Apr 2008 09:33:02 -0400
To: Matt S Trout <dbix-class [...] trout.me.uk>
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Matt S Trout wrote: [snip] Show quoted text
> This -is- your bug. > > the DBIx::Class tests themselves run fine without SQL::Translator because
Good for your tests. My tests however, use DBIx::Class deploy, as documented as public API, and it blows up on a version issue not listed in prereq. Show quoted text
> they provide a DDL file; deploy() only needs SQLT on the *build* side to > generate that file originally, which is why it's not marked as a dependency > on the DBIx::Class dist itself. > > Please fix UUIDColumns' tests. >
I do NOT use SQL::Translator directly. I make sure it is loaded, fulfilling the requirements in the deploy POD. DBIx::Class requires a specific version or it dies...a version not listed as a prereq [or in the pod]. Please fix your code, update your pod, or make it a prereq. Show quoted text
> C:\DBIx-Class-0.08010\DBIx-Class-0.08010>ack 0.08 > > lib\DBIx\Class\Storage\DBI.pm > 1332: $self->throw_exception(q{Can't create a ddl file without SQL::Translator 0.08: '} > 1482: $self->throw_exception(q{Can't deploy without SQL::Translator 0.08: '} > 1567: eval 'use SQL::Translator 0.08';
In no way should I have to inspect SQL::Translators version just to appease internal code in DBIx::Class. When that internal code changes (to require SQL::T 0.09 or something), now mine and every other dist using deploy has to change...again. That's bogons. deploy is described as: Show quoted text
> deploy > > Arguments: $sqlt_args, $dir > > Attempts to deploy the schema to the current storage using SQL::Translator. > > See "METHODS" in SQL::Translator for a list of values for $sqlt_args. The most common value for this would be { add_drop_table => 1, } to have the SQL produced include a DROP TABLE statement for each table created. > > Additionally, the DBIx::Class parser accepts a sources parameter as a hash ref or an array ref, containing a list of source to deploy. If present, then only the sources listed will get deployed.
And that's exactly how I'm using it. And it goes boom. It's not my fault it goes boom. -=Chris
Download signature.asc
application/pgp-signature 187b

Message body not shown because it is not plain text.

CC: dbix-class [...] lists.scsys.co.uk, bug-DBIx-Class-UUIDColumns [...] rt.cpan.org
Subject: Re: [Dbix-class] Re: [rt.cpan.org #35266] installs failed
Date: Tue, 22 Apr 2008 17:31:33 +0100
To: "Christopher H. Laco" <claco [...] chrislaco.com>
From: Matt S Trout <dbix-class [...] trout.me.uk>
On Tue, Apr 22, 2008 at 09:33:02AM -0400, Christopher H. Laco wrote: Show quoted text
> Matt S Trout wrote: > [snip] >
> >This -is- your bug. > > > >the DBIx::Class tests themselves run fine without SQL::Translator because
> > Good for your tests. My tests however, use DBIx::Class deploy, as > documented as public API, and it blows up on a version issue not listed > in prereq. >
> >they provide a DDL file; deploy() only needs SQLT on the *build* side to > >generate that file originally, which is why it's not marked as a dependency > >on the DBIx::Class dist itself. > > > >Please fix UUIDColumns' tests. > >
> > I do NOT use SQL::Translator directly. I make sure it is loaded, > fulfilling the requirements in the deploy POD. DBIx::Class requires a > specific version or it dies...a version not listed as a prereq [or in > the pod]. Please fix your code, update your pod, or make it a prereq.
It's not a prereq for basic operation, only for build-side usage of deploy. We don't make every DBD::* a prereq either. The correct way to use deploy here is the way DBIx::Class' tests use it - use SQL::Translator on the author side to generate a DDL file and make sure your tests can find that DDL file. You're right that the deploy POD should be updated to reflect this, but the -code- needing fixing is still the UUIDColumns tests. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/
CC: dbix-class [...] lists.scsys.co.uk, bug-DBIx-Class-UUIDColumns [...] rt.cpan.org
Subject: Re: [Dbix-class] Re: [rt.cpan.org #35266] installs failed
Date: Tue, 22 Apr 2008 13:04:52 -0400
To: Matt S Trout <dbix-class [...] trout.me.uk>
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Matt S Trout wrote: Show quoted text
> On Tue, Apr 22, 2008 at 09:33:02AM -0400, Christopher H. Laco wrote:
>> Matt S Trout wrote: >> [snip] >>
>>> This -is- your bug. >>> >>> the DBIx::Class tests themselves run fine without SQL::Translator because
>> Good for your tests. My tests however, use DBIx::Class deploy, as >> documented as public API, and it blows up on a version issue not listed >> in prereq. >>
>>> they provide a DDL file; deploy() only needs SQLT on the *build* side to >>> generate that file originally, which is why it's not marked as a dependency >>> on the DBIx::Class dist itself. >>> >>> Please fix UUIDColumns' tests. >>>
>> I do NOT use SQL::Translator directly. I make sure it is loaded, >> fulfilling the requirements in the deploy POD. DBIx::Class requires a >> specific version or it dies...a version not listed as a prereq [or in >> the pod]. Please fix your code, update your pod, or make it a prereq.
> > It's not a prereq for basic operation, only for build-side usage of > deploy. > > We don't make every DBD::* a prereq either. > > The correct way to use deploy here is the way DBIx::Class' tests use it > - use SQL::Translator on the author side to generate a DDL file and make > sure your tests can find that DDL file. > > You're right that the deploy POD should be updated to reflect this, but > the -code- needing fixing is still the UUIDColumns tests. >
Sigh. Most of this is me being in stubborn devil-on-the-left-shoulder mode...missing the important part: people can use the dist. I wonder if there's a decent way to do what gen-schema.pl does during make dist... Oddly enough, the tests for most of the dists I have that use deploy already use a sql file in the event that SQL::T isn't available.
Download signature.asc
application/pgp-signature 187b

Message body not shown because it is not plain text.

CC: dbix-class [...] lists.scsys.co.uk, bug-DBIx-Class-UUIDColumns [...] rt.cpan.org
Subject: Re: [Dbix-class] Re: [rt.cpan.org #35266] installs failed
Date: Wed, 23 Apr 2008 08:50:34 -0400
To: Matt S Trout <dbix-class [...] trout.me.uk>
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Matt S Trout wrote: Show quoted text
> On Tue, Apr 22, 2008 at 09:33:02AM -0400, Christopher H. Laco wrote:
>> Matt S Trout wrote: >> [snip] >>
>>> This -is- your bug. >>> >>> the DBIx::Class tests themselves run fine without SQL::Translator because
>> Good for your tests. My tests however, use DBIx::Class deploy, as >> documented as public API, and it blows up on a version issue not listed >> in prereq. >>
>>> they provide a DDL file; deploy() only needs SQLT on the *build* side to >>> generate that file originally, which is why it's not marked as a dependency >>> on the DBIx::Class dist itself. >>> >>> Please fix UUIDColumns' tests. >>>
>> I do NOT use SQL::Translator directly. I make sure it is loaded, >> fulfilling the requirements in the deploy POD. DBIx::Class requires a >> specific version or it dies...a version not listed as a prereq [or in >> the pod]. Please fix your code, update your pod, or make it a prereq.
> > It's not a prereq for basic operation, only for build-side usage of > deploy. > > We don't make every DBD::* a prereq either. > > The correct way to use deploy here is the way DBIx::Class' tests use it > - use SQL::Translator on the author side to generate a DDL file and make > sure your tests can find that DDL file. > > You're right that the deploy POD should be updated to reflect this, but > the -code- needing fixing is still the UUIDColumns tests. >
Cleaned up the easy way. Removed the use of deploy altogether in the tests in UUIDColumns, Validation and InflateColumn::Currency. No biggie for those since their test schema is a one off sql file for tests. For things like Handel/Mango, I'll just have to do it properly since the test schema is the codebase schema. -=Chris
Download signature.asc
application/pgp-signature 187b

Message body not shown because it is not plain text.

Fixed in 0.02004 available on CPAN. Same fixes applied to related dists: DBIx::Class::Validation and DBIx::Class::InflateColumn::Currency.