Bug #35249 for Net-Clickatell: UseSSL bug during initialisation

Mon Apr 21 03:07:42 2008 perl [...] abc-rallying.co.uk - Ticket created

Subject:

UseSSL bug during initialisation

I have been looking at using your perl module Net::Clickatell 0.10. I wrote some module tests to check the functionality and I noticed a couple of bugs. In 'new' the BASE_URL is always set to https even if UseSSL is set to zero. The condition 'if (exists $args{UseSSL})' should read 'if ($args{UseSSL})'. sendSIWAPPush uses a routine 'getTime' which is not defined. sendMMNotification defines a variable $tranid which is never used. I have attached the module test file which shows the BASE_URL bug, feel free to include the tests with the module distribution if you wish. You need to have Test::MockModule installed to complete all of the tests. I am running it on Activestate perl 5.8.8 817 under windows XP.

Subject:

01netClickatell.t

Message body is not shown because it is too large.

Mon Apr 21 10:38:22 2008 MOBILEART [...] cpan.org - Status changed from 'new' to 'open'

Mon Apr 21 10:38:48 2008 MOBILEART [...] cpan.org - Taken

Mon Apr 21 10:40:53 2008 MOBILEART [...] cpan.org - Correspondence added

Have made the changes. Attached is the new package.

Download Net-Clickatell-0.20.tgz
application/x-compressed 4.9k

Message body not shown because it is not plain text.

Mon Apr 21 10:41:01 2008 MOBILEART [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Apr 22 03:58:44 2008 perl [...] abc-rallying.co.uk - Correspondence added

On Mon Apr 21 10:40:53 2008, MOBILEART wrote: Show quoted text

> Have made the changes. > > Attached is the new package.

Thanks for the quick response. it has been fixed when the baseUrl has been supplied (line 208) but there is still a path through the code where the bug can show up (line 200) thanks, Ian

Tue Apr 22 03:58:45 2008 The RT System itself - Status changed from 'resolved' to 'open'

Tue Apr 22 05:56:22 2008 MOBILEART [...] cpan.org - Correspondence added

Please test it again. Let me know whether it works. Thanks.

Tue Apr 22 09:33:32 2008 ian [...] abc-rallying.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #35249] UseSSL bug during initialisation
Date:	Tue, 22 Apr 2008 14:33:05 +0100
To:	bug-Net-Clickatell [...] rt.cpan.org
From:	"Ian Clark" <ian [...] abc-rallying.co.uk>

"Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > Please test it again. Let me know whether it works. > > Thanks. > >

I have tried it against 0.20 and it still fails when UseSSL=>0, and BaseURL is not set. I have attached a small test script which shows the bug. Ian

Message body is not shown because sender requested not to inline it.

Tue Apr 22 21:17:12 2008 MOBILEART [...] cpan.org - Correspondence added

From:

MOBILEART [...] cpan.org

Sorry, I have attached the new version, some how you didn't get it. Alternatively, you can get it at: http://www.artofmobile.com/Net-Clickatell-0.21.tgz Please test it again. Let me know whether it works. Thanks. On Tue Apr 22 09:33:32 2008, ian@abc-rallying.co.uk wrote: Show quoted text

> "Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: >

> > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > > > Please test it again. Let me know whether it works. > > > > Thanks. > > > >

> > I have tried it against 0.20 and it still fails when UseSSL=>0, and > BaseURL is > not set. I have attached a small test script which shows the bug. > > Ian >

Download Net-Clickatell-0.21.tgz
application/x-compressed 5k

Message body not shown because it is not plain text.

Wed Apr 23 03:30:51 2008 ian [...] abc-rallying.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #35249] UseSSL bug during initialisation
Date:	Wed, 23 Apr 2008 08:30:27 +0100
To:	bug-Net-Clickatell [...] rt.cpan.org
From:	"Ian Clark" <ian [...] abc-rallying.co.uk>

Yes, that worked fine. Thanks for fixing it so quickly. Cheers, Ian "Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > Sorry, I have attached the new version, some how you didn't get it. > Alternatively, you can get it at: > > http://www.artofmobile.com/Net-Clickatell-0.21.tgz > > Please test it again. Let me know whether it works. > > > Thanks. > > On Tue Apr 22 09:33:32 2008, ian@abc-rallying.co.uk wrote:

> > "Christopherus Goo via RT" <bug-Net-Clickatell@rt.cpan.org> wrote: > >

> > > > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=35249 > > > > > > > Please test it again. Let me know whether it works. > > > > > > Thanks. > > > > > >

> > > > I have tried it against 0.20 and it still fails when UseSSL=>0, and > > BaseURL is > > not set. I have attached a small test script which shows the bug. > > > > Ian > >

> > > >

Sun Apr 27 21:53:45 2008 MOBILEART [...] cpan.org - Correspondence added

Problem resolved in version 0.2.1. A new version-- 0.3 is released.

Sun Apr 27 21:53:46 2008 MOBILEART [...] cpan.org - Status changed from 'open' to 'resolved'