Bug #35139 for Imager: fh parameter with fileno() == 0 is treated as unopened

Wed Apr 16 23:41:03 2008 christianc [...] sitesell.com - Ticket created

Subject:	bug in Imager 0.63
Date:	Thu, 17 Apr 2008 03:40:37 +0000
To:	bug-Imager [...] rt.cpan.org
From:	Christian Carey <christianc [...] sitesell.com>

Hello there, I believe that I’ve found a bug in Imager 0.63; fortunately, the bug is easily fixed. Within Imager.pm, in the _get_reader_io and _get_writer_io subroutines, at lines 1200 and 1251 respectively, is unless ($fd) { but these lines ought to be unless (defined $fd) { The reason for this is that a zero-value returned from fileno() [at lines 1199 and 1250 respectively] is a valid file descriptor value. Since fileno() returns undef rather than zero on a closed filehandle, the change outlined above should be applied to lines 1200 and 1251, so that the “Handle in fh option not opened” error is only generated when the filehandle is actually not open. Please let me know if you have any questions or concerns with the proposed fix above. I look forward to the next release of Imager — it will allow me to finish writing a regression test which depends upon this bug being fixed! Thank you, Christian. -- Christian Carey christianc@sitesell.com

Fri Apr 18 00:28:05 2008 TONYC [...] cpan.org - Subject changed from 'bug in Imager 0.63' to 'fh parameter with fileno() == 0 is treated as unopened'

Fri Apr 18 00:28:20 2008 TONYC [...] cpan.org - Severity Important added

Fri Apr 18 00:28:23 2008 TONYC [...] cpan.org - Broken in 0.63 added

Fri Apr 18 00:29:20 2008 TONYC [...] cpan.org - Priority changed from (no value) to '40'

Fri Apr 18 00:45:30 2008 TONYC [...] cpan.org - Correspondence added

On Wed Apr 16 23:41:03 2008, christianc@sitesell.com wrote: Show quoted text

> Hello there, > > I believe that I’ve found a bug in Imager 0.63; fortunately, the bug is > easily fixed. Within Imager.pm, in the _get_reader_io and _get_writer_io > subroutines, at lines 1200 and 1251 respectively, is > > unless ($fd) { > > but these lines ought to be > > unless (defined $fd) { > > The reason for this is that a zero-value returned from fileno() [at > lines 1199 and 1250 respectively] is a valid file descriptor value. > Since fileno() returns undef rather than zero on a closed filehandle, > the change outlined above should be applied to lines 1200 and 1251, so > that the “Handle in fh option not opened” error is only generated when > the filehandle is actually not open. > > Please let me know if you have any questions or concerns with the > proposed fix above. I look forward to the next release of Imager — it > will allow me to finish writing a regression test which depends upon > this bug being fixed!

Thank you for your report. This is fixed in svn. I expect I'll do a release soon, since a more serious bug has also been reported and fixed. Tony

Fri Apr 18 00:45:33 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 23 00:13:57 2008 TONYC [...] cpan.org - Correspondence added

On Wed Apr 16 23:41:03 2008, christianc@sitesell.com wrote: Show quoted text

> Hello there, > > I believe that I’ve found a bug in Imager 0.63; fortunately, the bug is > easily fixed. Within Imager.pm, in the _get_reader_io and _get_writer_io > subroutines, at lines 1200 and 1251 respectively, is > > unless ($fd) { > > but these lines ought to be > > unless (defined $fd) { > > The reason for this is that a zero-value returned from fileno() [at > lines 1199 and 1250 respectively] is a valid file descriptor value. > Since fileno() returns undef rather than zero on a closed filehandle, > the change outlined above should be applied to lines 1200 and 1251, so > that the “Handle in fh option not opened” error is only generated when > the filehandle is actually not open.

Hi, I've just released Imager 0.64 which fixes this problem. Tony

Wed Apr 23 00:18:41 2008 TONYC [...] cpan.org - Status changed from 'open' to 'resolved'