Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 35118
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: LIMAONE [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Apr 16 10:00:41 2008 LIMAONE [...] cpan.org - Ticket created
Subject: InputOutput::ProhibitJoinedReadline suggestion violates ProhibitPunctuationVars
InputOutput::ProhibitJoinedReadline suggests do { local $/ = undef; <$fh> } but it should be do { local $INPUT_RECORD_SEPARATOR = undef; <$fh> }; otherwise Perl::Critic reports a violation of ProhibitPunctuationVars
  Wed Apr 16 10:31:01 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #35118] InputOutput::ProhibitJoinedReadline suggestion violates ProhibitPunctuationVars
Date: Wed, 16 Apr 2008 09:30:33 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
LIMAONE via RT wrote: Show quoted text
> InputOutput::ProhibitJoinedReadline suggests > > do { local $/ = undef; <$fh> } > > but it should be > > do { local $INPUT_RECORD_SEPARATOR = undef; <$fh> }; > > otherwise Perl::Critic reports a violation of ProhibitPunctuationVars
I understand the complaint, but I'm not so sure that this should be the case. Use of English is independent of this module. What if the ProhibitPunctionationVars policy is disabled? The example would also need to include a "use English" statement, which is not germane to the discussion.
  Wed Apr 16 10:31:09 2008 The RT System itself - Status changed from 'new' to 'open'
  Wed Apr 16 10:43:01 2008 LIMAONE [...] cpan.org - Correspondence added
On Wed Apr 16 10:31:01 2008, clonezone wrote: Show quoted text
> > I understand the complaint, but I'm not so sure that this should be > the case. Use of English is independent of this module. What if > the ProhibitPunctionationVars policy is disabled? The example > would also need to include a "use English" statement, which is not > germane to the discussion.
makes sense. then I would just mention it in the pod.
  Mon Jan 26 14:37:33 2009 KYLE [...] cpan.org - Correspondence added
On Wed Apr 16 10:43:01 2008, LIMAONE wrote: Show quoted text
> On Wed Apr 16 10:31:01 2008, clonezone wrote:
> > > > I understand the complaint, but I'm not so sure that this should be > > the case. Use of English is independent of this module. What if > > the ProhibitPunctionationVars policy is disabled? The example > > would also need to include a "use English" statement, which is not > > germane to the discussion.
> > makes sense. then I would just mention it in the pod. >
I've put a note about this in the documentation as of revision 3079.
  Fri Mar 06 01:24:54 2009 thaljef [...] cpan.org - Correspondence added
This has been completed and released in Perl-Critic-1.097_002. http://search.cpan.org/~elliotjs/Perl-Critic-1.097_002 Thank you for submitting this ticket.
  Fri Mar 06 01:24:55 2009 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'