| Subject: | Exit with 0 in Makefile.PL When WAIT Directory Is Not Available |
Dear Ulrich Pfeifer,
Hi. This is imacat from Taiwan. I found that the Makefile.PL in
your WAIT-1.800 goes into an infinite loop if nothing is read from
keyboard. I would suggest you to exit() with 0 from the Makefile.PL if
the required WAIT directory fails, as suggested by this article:
<<Notes For CPAN Authors>
"How can I stop getting FAIL reports for missing libraries or other
non-Perl dependencies?"
http://cpantest.grango.org/wiki/CPANAuthorNotes
I made a simple patch to WAIT-1.800, in the hope that it helps.
Please tell me if you have any question, or if I could be of any help.
Thank you.
| Subject: | WAIT-1.800-noloop.diff |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
diff -u -r WAIT-1.800.orig/Makefile.PL WAIT-1.800/Makefile.PL
- --- WAIT-1.800.orig/Makefile.PL 2000-04-09 22:17:46.000000000 +0800
+++ WAIT-1.800/Makefile.PL 2008-04-16 10:39:10.000000000 +0800
@@ -91,6 +91,10 @@
$answer = $WAIT::Config->{WAIT_home};
$answer = '' unless $answer && -d $answer;
$answer = prompt("WAIT database directory?", $answer) unless $use_defaults;
+ if (!$answer) {
+ print STDERR "Cannot continue without WAIT database directory\n";
+ exit 0;
+ }
mkpath($answer) unless $answer && -d $answer; # dies if it can't
$WAIT::Config->{WAIT_home} = $answer;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkgFZu4ACgkQi9gubzC5S1yqCwCfSKdjpzVA7UAo464f1EAUHHlJ
3qgAn1eqMfv5xlX1zGnSZGHp91v8uzBy
=J0mi
-----END PGP SIGNATURE-----