| Subject: | Comment field names should be case-insensitive |
| Date: | Sat, 12 Apr 2008 14:35:41 +0200 |
| To: | bug-Ogg-Vorbis-Header [...] rt.cpan.org |
| From: | gregor herrmann <gregor+debian [...] comodo.priv.at> |
Hi,
we have a bug report in the Debian Bug Tracking System that points
out that lower-casing comment fields names violates the Vorbis
specification [0]:
http://bugs.debian.org/315985
Here's a trivial patch for this problem:
--- libogg-vorbis-header-perl.orig/Header.pm
+++ libogg-vorbis-header-perl/Header.pm
@@ -71,7 +71,6 @@
while ($#comments >= 0) {
my $key = shift @comments;
$key =~ s/[^\x20-\x3C\x3E-\x7D]//g;
- $key = lc($key);
my $val = shift @comments;
$val =~ s/[^\x20-\x7D]//g;
push @{$self->{COMMENTS}->{$key}}, $val;
Please consider applying this change to the module.
Cheers,
gregor (Debian Perl Group)
[0]
http://xiph.org/vorbis/doc/Vorbis_I_spec.html#vorbis-spec-comment
"The field name is case-insensitive and may consist of ..."
--
.''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
: :' : debian: the universal operating system - http://www.debian.org/
`. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/
`- NP: Ludwig Hirsch: Bitter
Message body not shown because it is not plain text.