Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 34838
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: brbpub [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Apr 10 13:57:41 2008 brbpub [...] gmail.com - Ticket created
Subject: RequireUseStrict and RequireUseWarnings don't handle Moose::Role
Date: Thu, 10 Apr 2008 13:57:05 -0400
To: bug-Perl-Critic [...] rt.cpan.org
From: Bernardo Rechea <brbpub [...] gmail.com>
In the same way that an exception is made for 'use Moose' as being equivalent to 'use strict' and 'use warnings', an exception should be made for 'use Moose::Role, because it also enables strict and warnings. Changing the third test in subs _is_use_strict() and _is_use_warnings() from return 0 if $elem->pragma() ne 'strict' && $elem->module() ne 'Moose'; to return 0 if $elem->pragma() ne 'strict' && $elem->module() !~ /^Moose(?:::Role)?$/; adds the exception for Moose::Role. I'm running Perl::Critic v1.802 with Perl 5.10 on SuSE Linux 10.2. Bernardo Rechea
  Thu Apr 10 14:47:11 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #34838] RequireUseStrict and RequireUseWarnings don't handle Moose::Role
Date: Thu, 10 Apr 2008 13:46:50 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Bernardo Rechea via RT wrote: Show quoted text
> In the same way that an exception is made for 'use Moose' as being equivalent > to 'use strict' and 'use warnings', an exception should be made for 'use > Moose::Role, because it also enables strict and warnings.
I'll look into it.
  Thu Apr 10 14:47:13 2008 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 13 22:19:06 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #34838] RequireUseStrict and RequireUseWarnings don't handle Moose::Role
Date: Sun, 13 Apr 2008 21:18:54 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Elliot Shank via RT wrote: Show quoted text
> Bernardo Rechea via RT wrote:
>> In the same way that an exception is made for 'use Moose' as being >> equivalent to 'use strict' and 'use warnings', an exception should >> be made for 'use Moose::Role, because it also enables strict and >> warnings.
> > I'll look into it.
Checked in. It'll be in the next release.
  Tue Apr 15 10:27:21 2008 brbpub [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #34838] RequireUseStrict and RequireUseWarnings don't handle Moose::Role
Date: Tue, 15 Apr 2008 10:26:01 -0400
To: bug-Perl-Critic [...] rt.cpan.org
From: Bernardo Rechea <brbpub [...] gmail.com>
Thanks for such a speedy fix! On Sunday 13 April 2008, Elliot Shank via RT wrote: Show quoted text
> > Checked in. It'll be in the next release.
  Sat May 24 16:18:05 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #34838] RequireUseStrict and RequireUseWarnings don't handle Moose::Role
Date: Sat, 24 May 2008 15:17:47 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Released in 1.084 today.
  Tue May 27 12:59:52 2008 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'