| Subject: | "make test" Hangs at t/03-entry_class.t when Catalyst::Model::LDAP Missing |
ear Peter Karman,
Hi. This is imacat from Taiwan. I found that your
Catalyst-Authentication-Store-LDAP-0.1000 hangs at t/03-entry_class.t
during "make test" when Catalyst::Model::LDAP is missing. I tried to
dig into the code. It seems that the spawn LDAPTest::spawn_server()
does not shutdown after skipping the tests for the missing
Catalyst::Model::LDAP. I suppose it should skip the tests before
spawning the server.
The terminal log is attached below. I made a simple patch against
your Catalyst-Authentication-Store-LDAP-0.1000, in the hope that it
helps. Please tell me if there is any problem, or if I could be of any
help. Thank you.
imacat@rinse tmp/Catalyst-Authentication-Store-LDAP-0.1000 % perl -v
This is perl, v5.8.8 built for x86_64-linux-thread-multi-ld
Copyright 1987-2006, Larry Wall
Perl may be copied only under the terms of either the Artistic License
or the
GNU General Public License, which may be found in the Perl 5 source kit.
Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl". If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.
imacat@rinse tmp/Catalyst-Authentication-Store-LDAP-0.1000 % perl
Makefile.PL
*** Module::AutoInstall version 1.03
*** Checking for Perl dependencies...
[Core Features]
- Net::LDAP::Server::Test ...loaded. (0.02 >= 0.02)
- Test::More ...loaded. (0.78)
- Net::LDAP ...loaded. (0.35)
- Catalyst::Plugin::Authentication ...loaded. (0.10006 >= 0.10003)
*** Module::AutoInstall configuration finished.
Checking if your kit is complete...
Looks good
Writing Makefile for Catalyst::Authentication::Store::LDAP
imacat@rinse tmp/Catalyst-Authentication-Store-LDAP-0.1000 % make
cp lib/Catalyst/Authentication/Store/LDAP.pm
blib/lib/Catalyst/Authentication/Store/LDAP.pm
cp lib/Catalyst/Authentication/Store/LDAP/User.pm
blib/lib/Catalyst/Authentication/Store/LDAP/User.pm
cp lib/Catalyst/Authentication/Store/LDAP/Backend.pm
blib/lib/Catalyst/Authentication/Store/LDAP/Backend.pm
Manifying blib/man3/Catalyst::Authentication::Store::LDAP::User.3
Manifying blib/man3/Catalyst::Authentication::Store::LDAP.3
Manifying blib/man3/Catalyst::Authentication::Store::LDAP::Backend.3
imacat@rinse tmp/Catalyst-Authentication-Store-LDAP-0.1000 % make test
t/02-realms_api.......creating new LDAP server on port 10636 ...
t/02-realms_api.......1/5 ... shutting down server
t/02-realms_api.......ok
t/03-entry_class......creating new LDAP server on port 10636 ...
t/03-entry_class......1/6 make: *** wait: No child processes. Stop.
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes. Stop.
imacat@rinse tmp/Catalyst-Authentication-Store-LDAP-0.1000 % perl
-Iblib/lib -Iblib/arch t/03-entry_class.t
1..6
creating new LDAP server on port 10636 ...
ok 1 # skip Catalyst::Model::LDAP not installed
ok 2 # skip Catalyst::Model::LDAP not installed
ok 3 # skip Catalyst::Model::LDAP not installed
ok 4 # skip Catalyst::Model::LDAP not installed
ok 5 # skip Catalyst::Model::LDAP not installed
ok 6 # skip Catalyst::Model::LDAP not installed
imacat@rinse tmp/Catalyst-Authentication-Store-LDAP-0.1000 %
| Subject: | Catalyst-Authentication-Store-LDAP-0.1000-skipall.diff |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
diff -u -r Catalyst-Authentication-Store-LDAP-0.1000.orig/t/03-entry_class.t Catalyst-Authentication-Store-LDAP-0.1000/t/03-entry_class.t
- --- Catalyst-Authentication-Store-LDAP-0.1000.orig/t/03-entry_class.t 2008-02-05 04:38:48.000000000 +0800
+++ Catalyst-Authentication-Store-LDAP-0.1000/t/03-entry_class.t 2008-04-09 10:08:20.000000000 +0800
@@ -4,18 +4,18 @@
use warnings;
use Catalyst::Exception;
- -use Test::More tests => 6;
+use Test::More;
use lib 't/lib';
use LDAPTest;
+eval "use Catalyst::Model::LDAP";
+if ($@) {
+ plan skip_all => "Catalyst::Model::LDAP not installed";
+}
+plan tests => 6;
my $server = LDAPTest::spawn_server();
SKIP: {
- - eval "use Catalyst::Model::LDAP";
- - if ($@) {
- - skip "Catalyst::Model::LDAP not installed", 6;
- - }
- -
use_ok("Catalyst::Authentication::Store::LDAP::Backend");
my $back = Catalyst::Authentication::Store::LDAP::Backend->new(
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkf8JSAACgkQi9gubzC5S1zsygCdEyfwaXqyybmx0siKMGAWmSKQ
OrgAoJa8M9TZxG5kV76JJO7oOkZJX1CD
=XFq5
-----END PGP SIGNATURE-----