Skip Menu |

This queue is for tickets about the Apache-DebugLog CPAN distribution.

Report information
The Basics
Id: 34628
Status: open
Priority: 0/
Queue: Apache-DebugLog

People
Owner: dorian [...] cpan.org
Requestors: imacat [...] mail.imacat.idv.tw
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.02
Fixed in: (no value)



Subject: exit() with 0 Instead of die() in Makefile.PL
Dear Dorian Taylor, Hi. This is imacat from Taiwan. I found that the Makefile.PL in your Apache-DebugLog-0.02 die() when mod_perl version is insane. I would like to suggest you to exit() with 0 instead of die() in your Makefile.PL, as suggested by this article: <<Notes For CPAN Authors> "How can I stop getting FAIL reports for missing libraries or other non-Perl dependencies?" http://cpantest.grango.org/wiki/CPANAuthorNotes I made a simple patch to Apache-DebugLog-0.02, in the hope that it helps. Please tell me if you have any question, or if I could be of any help. Thank you.
Subject: Apache-DebugLog-0.02-exit0.diff
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 diff -u -r Apache-DebugLog-0.02.orig/Makefile.PL Apache-DebugLog-0.02/Makefile.PL - --- Apache-DebugLog-0.02.orig/Makefile.PL 2005-07-15 05:20:48.000000000 +0800 +++ Apache-DebugLog-0.02/Makefile.PL 2008-04-03 02:01:25.000000000 +0800 @@ -14,9 +14,11 @@ eval { require mod_perl }; if (!$@) { - - die "Incompatible version of mod_perl 2. Please upgrade." - - if ($mod_perl::VERSION >= 1.99); - - + if ($mod_perl::VERSION >= 1.99) { + # sorry we can't do pre-rc5 mod_perl2. + print STDERR "Incompatible version of mod_perl 2. Please upgrade." + exit 0; + } # earliest sane mod_perl 1? $PREREQ_PM->{'mod_perl'} = 1.24_01; -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkfzyiQACgkQi9gubzC5S1xKLwCgiwUJeIRhZCrYUBoNksq8G6F0 hpYAniQSVlucC5FA32hSPAW3ho3QW0m8 =EBpU -----END PGP SIGNATURE-----
Subject: Re: [rt.cpan.org #34628] exit() with 0 Instead of die() in Makefile.PL
Date: Wed, 2 Apr 2008 11:38:37 -0700
To: bug-Apache-DebugLog [...] rt.cpan.org
From: "dorian taylor" <dorian.taylor [...] gmail.com>
imacat, I'm going to be upgrading all these modules to Module::Install in the next few weeks; the MP2 betas (before the namespace switch) are so old anyway that I can probably take that code fork out completely. Thanks for bringing this to my attention. Dorian