Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 34401
Status: resolved
Priority: 0/
Queue: Log-Log4perl
People
Owner: Nobody in particular
Requestors: jgangemi@gmail.com (no email address)
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Mar 24 11:19:00 2008 jgangemi [...] gmail.com - Ticket created
Subject: Util::module_available broken for code references
Log::Log4perl::Util::module_available does not work properly for code references that may reside in @INC. the attached patch fixes that issue. this may be related to bug 24884 as well.
Subject: Util.diff
Index: Util.pm =================================================================== RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Util.pm,v retrieving revision 1.5 diff -r1.5 Util.pm 29c29 < return 1 if $dir->($dir, $relpath); --- > return 1 if $dir->($dir, $relpath_with_forward_slashes); 31c31 < return 1 if $dir->[0]->($dir, $relpath); --- > return 1 if $dir->[0]->($dir, $relpath_with_forward_slashes);
  Sun Aug 24 01:53:13 2008 MSCHILLI [...] cpan.org - Correspondence added
On Mon Mar 24 11:19:00 2008, JAE wrote: Show quoted text
> Log::Log4perl::Util::module_available does not work properly for code > references that may reside in @INC. > > the attached patch fixes that issue. this may be related to bug 24884 as > well.
Are you sure? This would only be different if File::Spec->catfile() uses something other than '/' as a delimiter. Can you provide a test case?
  Sun Aug 24 01:53:14 2008 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 25 10:16:44 2008 jgangemi [...] gmail.com - Correspondence added
On Sun Aug 24 01:53:13 2008, MSCHILLI wrote: Show quoted text
> On Mon Mar 24 11:19:00 2008, JAE wrote:
> > Log::Log4perl::Util::module_available does not work properly for code > > references that may reside in @INC. > > > > the attached patch fixes that issue. this may be related to bug 24884 as > > well.
> > Are you sure? This would only be different if File::Spec->catfile() uses > something other than '/' as a delimiter. Can you provide a test case?
hrm - i'll have to see what i can do about that, we see this b/c we have a coderef as part of @INC, and i'm not 100% sure how to best reproduce that outside of our environment.
  Tue Aug 26 02:02:48 2008 MSCHILLI [...] cpan.org - Correspondence added
On Mon Aug 25 10:16:44 2008, JAE wrote: Show quoted text
> hrm - i'll have to see what i can do about that, we see this b/c we have > a coderef as part of @INC, and i'm not 100% sure how to best reproduce > that outside of our environment.
I can see it happening on Windows, but I take it you're running some kind of Unix?
  Tue Aug 26 09:47:01 2008 jgangemi [...] gmail.com - Correspondence added
On Tue Aug 26 02:02:48 2008, MSCHILLI wrote: Show quoted text
> On Mon Aug 25 10:16:44 2008, JAE wrote: >
> > hrm - i'll have to see what i can do about that, we see this b/c we have > > a coderef as part of @INC, and i'm not 100% sure how to best reproduce > > that outside of our environment.
> > I can see it happening on Windows, but I take it you're running some > kind of Unix?
we run on a bunch of different unix flavors and windows, which is where the issue occurs for us.
  Tue Sep 08 11:39:36 2009 MSCHILLI [...] cpan.org - Correspondence added
Sorry for the long wait, finally applied your patch: http://github.com/mschilli/log4perl/commit/14ae276817842ba33818792e96a3b0d3e258fe3b Thanks for your contribution. -- Mike
  Tue Sep 08 11:39:37 2009 MSCHILLI [...] cpan.org - Status changed from 'open' to 'resolved'