Bug #34099 for Net-Server-Mail: bug: duplicated leading dot

Fri Mar 14 16:25:43 2008 attila [...] netalfa.hu - Ticket created

Subject:	bug: duplicated leading dot
Date:	Fri, 14 Mar 2008 21:25:06 +0100
To:	bug-Net-Server-Mail [...] rt.cpan.org
From:	bognár attila <attila [...] netalfa.hu>

Dear Xavier, I found a bug in Net-Server-Mail (http://search.cpan.org/~guimard/Net-Server-Mail/): when there is a leading dot in the message and it is duplicated for sending through smtp, this leading double dot is not deduplicated before passing it to the process subroutine. Yours, Attila

Mon Mar 17 10:14:39 2008 x.guimard [...] free.fr - Correspondence added

RT-Send-CC:

attila [...] netalfa.hu

Le Ven. Mar. 14 16:25:43 2008, attila@netalfa.hu a écrit : Show quoted text

> Dear Xavier, > > I found a bug in Net-Server-Mail > (http://search.cpan.org/~guimard/Net-Server-Mail/): when there is a > leading dot in the message and it is duplicated for sending through > smtp, this leading double dot is not deduplicated before passing it to > the process subroutine. > > Yours, > > Attila

Hi, I found the bug: this is a RFC 2821 feature: points in the beginning of lines are duplicated. So Net-Server-Mail has to remove them. The regular expression is derived from Amavis. Thank you for your contribution.

diff -aburN Net-Server-Mail-0.16/lib/Net/Server/Mail/SMTP.pm Net-Server-Mail-0.16-new/lib/Net/Server/Mail/SMTP.pm --- Net-Server-Mail-0.16/lib/Net/Server/Mail/SMTP.pm 2007-05-26 09:48:35.000000000 +0200 +++ Net-Server-Mail-0.16-new/lib/Net/Server/Mail/SMTP.pm 2008-03-17 15:10:51.000000000 +0100 @@ -596,8 +596,10 @@ } # RFC 821 compliance. - ($data = "$self->{last_chunk}$data") =~ s/(\r?\n)\.\r?\n(QUIT\r?\n)?/$1/s; + ($data = "$self->{last_chunk}$data") =~ s/(\r?\n)\.\r?\n(QUIT\r?\n)?$/$1/s; $self->{_data} .= $data; + # RFC 2821 by the letter + $self->{_data} =~ s/^\.(.+\015\012)(?!\n)/$1/gm; return $self->data_finished($more_data); }

Mon Mar 17 10:14:46 2008 The RT System itself - Status changed from 'new' to 'open'

Mon Mar 17 10:44:09 2008 x.guimard [...] free.fr - Correspondence added 60 min

Fixed in version 0.17

Mon Mar 17 10:45:11 2008 x.guimard [...] free.fr - Correspondence added 60 min

Fixed in version 0.17

Mon Mar 17 10:45:28 2008 x.guimard [...] free.fr - Status changed from 'open' to 'resolved'

Mon Mar 17 10:46:00 2008 x.guimard [...] free.fr - Correspondence added 60 min

Fixed in version 0.17

Mon Mar 17 10:46:20 2008 The RT System itself - Status changed from 'resolved' to 'open'

Mon Mar 17 10:46:22 2008 x.guimard [...] free.fr - Given to GUIMARD

Mon Mar 17 10:47:20 2008 x.guimard [...] free.fr - Status changed from 'open' to 'resolved'

Mon Mar 17 10:48:42 2008 x.guimard [...] free.fr - Severity Normal added

Mon Mar 17 10:48:47 2008 x.guimard [...] free.fr - Broken in 0.01 added

Thu Mar 20 17:53:15 2008 x.guimard [...] free.fr - Fixed in 0.17 added