Skip Menu |

This queue is for tickets about the MARC-XML CPAN distribution.

Report information
The Basics
Id: 34082
Status: resolved
Priority: 0/
Queue: MARC-XML

People
Owner: Nobody in particular
Requestors: dueberb [...] umich.edu
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: MARC::File::XML Bug: header logic in method "record"
Date: Fri, 14 Mar 2008 08:59:58 -0400
To: bug-MARC-XML [...] rt.cpan.org
From: Bill Dueber <dueberb [...] umich.edu>
$VERSION = '0.88'; This is perl, v5.8.6 built for darwin-thread-multi-2level (with 4 registered patches, see perl -V for more detail) The include/exclude header logic is reversed in method "record", about line 333; Instead of "if ($without_header) { ...it should be unless ($without_header) { ... This'll show up as a warning: Use of uninitialized value in concatenation (.) or string at /Library/ Perl/5.8.6/MARC/File/XML.pm line 334. ...if you call "as_xml_record" due to the encoding not being passed along. Thanks! -Bill Dueber-
On Fri Mar 14 09:00:45 2008, dueberb@umich.edu wrote: Show quoted text
> The include/exclude header logic is reversed in method "record", > about line 333; > > Instead of "if ($without_header) { > > ...it should be > > unless ($without_header) { ...
Check out the following diff, which renames the variables controlling the output of the collection and record headers for greater clarity: http://marcpm.cvs.sourceforge.net/viewvc/marcpm/marc-xml/lib/MARC/File/XML.pm?r1=1.43&r2=1.44 Please let me know if this addresses the problem. If you have a test case that can produce the warning using the MARC::File::XML API as documented, please attach it.
Bug confirmed resolved.