Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 34051
Status: resolved
Priority: 0/
Queue: Log-Log4perl

People
Owner: MSCHILLI [...] cpan.org
Requestors: Mitchell.Perilstein [...] trueposition.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: 5005it.pl needs to handle binmode
Date: Thu, 13 Mar 2008 12:20:39 -0400
To: <bug-Log-Log4perl [...] rt.cpan.org>
From: "Perilstein, Mitchell" <Mitchell.Perilstein [...] trueposition.com>
binmode() takes two arguments starting in 5.6.0. Prior to that, it only takes one. Appender/File.pm calls it, for example. This change at install time will remove the second arg from binmode calls. $ diff 5005it.pl* 51,54d50 < # Anything before 5.6.0 doesn't have the two argument binmode. < # Convert to one arg version by discarding second arg. < $data =~ s{ binmode \s* \(? (.*?) , .* \)? \s* ; }{ "binmode $1 ;" }gex; < Regards, -m
Applied in CVS, will be released with 1.16. Thanks for the patch! -- Mike