Bug #34048 for Module-Pluggable: Must install in 'perl' dirs

Thu Mar 13 11:08:29 2008 jdhedden [...] cpan.org - Ticket created

Subject:

Must install in 'perl' dirs

Module-Pluggable is now a core Perl module. However, the CPAN distribution updates into the 'site' dirs. Because the core dirs come before the site dirs in @INC, the newer version is not used. The following patch corrects this: --- Module-Pluggable-3.7/Makefile.PL +++ Module-Pluggable-3.7/Makefile.PL @@ -34,7 +34,7 @@ 'File::Spec' => '3.00', 'Test::More' => '0.62' }, - 'INSTALLDIRS' => 'site', + 'INSTALLDIRS' => 'perl', 'EXE_FILES' => [], 'PL_FILES' => {} )

Thu Mar 13 12:49:18 2008 simonw [...] cpan.org - Correspondence added

Thanks for this. It's actually already patched in svn although the word from p5p was that the correct magic to use was 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site", I should be rolling a new release either today or tomorrow (I just want to wait a bit to see if any other issues crop up).

Thu Mar 13 12:49:20 2008 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 13 12:49:21 2008 simonw [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Mar 17 10:48:26 2008 jdhedden [...] cpan.org - Correspondence added

Show quoted text

> 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site",

Turns out this is not correct either. Because Module::Pluggable has now been moved under 'ext' in core, Pluggable.pm gets installed into $Config{installarchlib}. However, the above causes an update from CPAN to install Pluggable.pm into $Config{installprivlib}. Since installarchlib comes before installprivlib in @INC, the CPAN upgrade gets masked.

Mon Mar 17 10:48:31 2008 The RT System itself - Status changed from 'resolved' to 'open'

Mon Mar 17 11:07:01 2008 jdhedden [...] cpan.org - Correspondence added

Show quoted text

> > 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site",

> > Turns out this is not correct either. Because Module::Pluggable has now > been moved under 'ext' in core, Pluggable.pm gets installed into > $Config{installarchlib}. However, the above causes an update from CPAN > to install Pluggable.pm into $Config{installprivlib}. Since > installarchlib comes before installprivlib in @INC, the CPAN upgrade > gets masked.

I have tested the following (also attached), and it seems to fix the problem: --- Module-Pluggable-3.8/Makefile.PL.orig +++ Module-Pluggable-3.8/Makefile.PL @@ -41,6 +41,7 @@ }, 'EXE_FILES' => [], 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site", + 'INST_LIB' => 'blib/arch', 'PL_FILES' => {}, 'realclean' => {FILES=> join ' ', @files}, # In the core pods will be built by installman.

--- Module-Pluggable-3.8/Makefile.PL.orig 2008-03-17 11:03:17.848284100 -0400 +++ Module-Pluggable-3.8/Makefile.PL 2008-03-17 11:05:02.034826500 -0400 @@ -41,6 +41,7 @@ }, 'EXE_FILES' => [], 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site", + 'INST_LIB' => 'blib/arch', 'PL_FILES' => {}, 'realclean' => {FILES=> join ' ', @files}, # In the core pods will be built by installman.

Mon Mar 17 11:13:41 2008 jdhedden [...] cpan.org - Correspondence added

On Mon Mar 17 11:07:01 2008, JDHEDDEN wrote: Show quoted text

> > > 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site",

> > > > Turns out this is not correct either. Because Module::Pluggable has now > > been moved under 'ext' in core, Pluggable.pm gets installed into > > $Config{installarchlib}. However, the above causes an update from CPAN > > to install Pluggable.pm into $Config{installprivlib}. Since > > installarchlib comes before installprivlib in @INC, the CPAN upgrade > > gets masked.

> > I have tested the following (also attached), and it seems to fix the > problem: > > --- Module-Pluggable-3.8/Makefile.PL.orig > +++ Module-Pluggable-3.8/Makefile.PL > @@ -41,6 +41,7 @@ > }, > 'EXE_FILES' => [], > 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site", > + 'INST_LIB' => 'blib/arch', > 'PL_FILES' => {}, > 'realclean' => {FILES=> join ' ', @files}, > # In the core pods will be built by installman.

Sorry about that. I realized that the added line needs to be conditionalized, too: --- Module-Pluggable-3.8/Makefile.PL.orig +++ Module-Pluggable-3.8/Makefile.PL @@ -41,6 +41,7 @@ }, 'EXE_FILES' => [], 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site", + 'INST_LIB' => ($] >= 5.008009) ? 'blib/arch' ? 'blib/lib', 'PL_FILES' => {}, 'realclean' => {FILES=> join ' ', @files}, # In the core pods will be built by installman.

--- Module-Pluggable-3.8/Makefile.PL.orig 2008-03-17 11:03:17.848284100 -0400 +++ Module-Pluggable-3.8/Makefile.PL 2008-03-17 11:05:02.034826500 -0400 @@ -41,6 +41,7 @@ }, 'EXE_FILES' => [], 'INSTALLDIRS' => ($] >= 5.008009) ? "perl" : "site", + 'INST_LIB' => ($] >= 5.008009) ? 'blib/arch' ? 'blib/lib', 'PL_FILES' => {}, 'realclean' => {FILES=> join ' ', @files}, # In the core pods will be built by installman.

Wed Mar 26 15:14:59 2008 simonw [...] cpan.org - Taken

Wed Mar 26 15:15:38 2008 simonw [...] cpan.org - Correspondence added

Fixed in SVN.

Wed Mar 26 15:15:45 2008 simonw [...] cpan.org - Status changed from 'open' to 'resolved'