Bug #33964 for Params-Validate: pod-coverage test failure

Mon Mar 10 13:29:16 2008 KEVINR [...] cpan.org - Ticket created

CC:	kevinr [...] mit.edu, jesse [...] bestpractical.com
Subject:	pod-coverage test failure

I'm seeing a failure on Params::Validate 0.89's pod-coverage test, with Test::Pod::Coverage 1.08 under a custom Perl 5.8.8 on Debian etch x86_64-linux. (I'm building the Jifty Shipwright repository. I pinged Jesse to see if it was a problem with Shipwright, and he asked me to report it to you.) t/pod-coverage..............Prototype mismatch: sub Params::Validate::validate (\@$) vs none at /home/kevinr/jifty-builder/dists/cpan-Params-Validate/blib/lib/Params/ValidateXS.pm line 131. Prototype mismatch: sub Params::Validate::validate_pos (\@@) vs none at /home/kevinr/jifty-builder/dists/cpan-Params-Validate/blib/lib/Params/ValidateXS.pm line 132. # Failed test 'Pod coverage on Params::Validate' # at /tmp/jifty-builder-vmtCS0/jifty-builder/lib/perl5/site_perl/5.8.8/Test/Pod/Coverage.pm line 126. # Coverage for Params::Validate is 70.6%, with 5 naked subroutines: # UNKNOWN # set_options # validate # validate_pos # validate_with # Looks like you failed 1 test of 4. t/pod-coverage..............dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 2 Failed 1/4 tests, 75.00% okay - Kevin -- Kevin Riggle <kevinr@mit.edu>

Mon Mar 10 13:29:29 2008 KEVINR [...] cpan.org - Broken in 0.89 added

Fri Mar 21 19:05:58 2008 DROLSKY [...] cpan.org - Correspondence added

On Mon Mar 10 13:29:16 2008, KEVINR wrote: Show quoted text

> I'm seeing a failure on Params::Validate 0.89's pod-coverage test, > with > Test::Pod::Coverage 1.08 under a custom Perl 5.8.8 on Debian etch > x86_64-linux. (I'm building the Jifty Shipwright repository. I > pinged > Jesse to see if it was a problem with Shipwright, and he asked me to > report it to you.) > > t/pod-coverage..............Prototype mismatch: sub > Params::Validate::validate (\@$) vs none at > /home/kevinr/jifty-builder/dists/cpan-Params- > Validate/blib/lib/Params/ValidateXS.pm > line 131. > Prototype mismatch: sub Params::Validate::validate_pos (\@@) vs none > at > /home/kevinr/jifty-builder/dists/cpan-Params- > Validate/blib/lib/Params/ValidateXS.pm > line 132.

The pod tests are really intended to only be run by me, and they pass for me just fine. Are you running this from an svn checkout? That'll cause these tests to be run, since they're normally skipped.

Fri Mar 21 19:05:59 2008 The RT System itself - Status changed from 'new' to 'open'

Fri Apr 18 13:06:58 2008 DROLSKY [...] cpan.org - Status changed from 'open' to 'rejected'

Fri May 30 12:41:17 2008 spang [...] mit.edu - Correspondence added

From:

spang [...] bestpractical.com

On Fri Mar 21 19:05:58 2008, DROLSKY wrote: Show quoted text

> The pod tests are really intended to only be run by me, and they pass > for me just fine. Are you running this from an svn checkout? That'll > cause these tests to be run, since they're normally skipped.

Would you be willing to accept a patch to not check for .svn in order to decide when to run these tests? If you're setting $IS_MAINTAINER, the tests should still run for you just fine, and this would allow other sites to track Params::Validate in SVN without forcing them to be run.

Fri May 30 12:41:20 2008 The RT System itself - Status changed from 'rejected' to 'open'

Fri May 30 15:38:29 2008 autarch [...] urth.org - Correspondence added

Subject:	Re: [rt.cpan.org #33964] pod-coverage test failure
Date:	Fri, 30 May 2008 14:37:24 -0500 (CDT)
To:	Christine Spang via RT <bug-Params-Validate [...] rt.cpan.org>
From:	Dave Rolsky <autarch [...] urth.org>

On Fri, 30 May 2008, Christine Spang via RT wrote: Show quoted text

> > Queue: Params-Validate > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=33964 > > > On Fri Mar 21 19:05:58 2008, DROLSKY wrote:

>> The pod tests are really intended to only be run by me, and they pass >> for me just fine. Are you running this from an svn checkout? That'll >> cause these tests to be run, since they're normally skipped.

> > Would you be willing to accept a patch to not check for .svn in order to > decide when to run these tests? If you're setting $IS_MAINTAINER, the > tests should still run for you just fine, and this would allow other > sites to track Params::Validate in SVN without forcing them to be run.

It's really convenient for me to just run "prove" and get all the tests run as part of my dev cycle. I don't want to make my process more complicated. As it is, those tests should be skipped if you don't have the needed modules installed, and it's not like running them does any harm. -dave /*========================== VegGuide.Org Your guide to all that's veg ==========================*/

Sun Jul 27 17:05:34 2008 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'