Sun Mar 09 18:03:27 2008perl [...] galumph.com - Ticket created
CC:
Heiko <heiko [...] hexco.de>
Subject:
RequireArgUnpacking doesn't handle assignment to variables outside subroutine scope.
Date:
Sun, 09 Mar 2008 17:03:10 -0500
To:
bug-Perl-Critic [...] rt.cpan.org
From:
Elliot Shank <perl [...] galumph.com>
Subroutines::RequireArgUnpacking
gives
Always unpack @_ first at line 10, column 1. See page 178 of PBP. (Severity: 4)
on this code
my $y;
sub set_y
{
my $x;
($y, $x) = @_;
return;
}
The workaround would be to use
($y, my $x) = @_;
instead of
my $x;
($y, $x) = @_;
Sun Mar 09 18:57:24 2008perl [...] galumph.com - Correspondence added
> Subroutines::RequireArgUnpacking
> gives
> Always unpack @_ first at line 10, column 1. See page 178 of PBP. (Severity: 4)
> on this code
>
> my $y;
>
> sub set_y
> {
> my $x;
> ($y, $x) = @_;
> return;
> }
>
> The workaround would be to use
> ($y, my $x) = @_;
> instead of
> my $x;
> ($y, $x) = @_;
That's not a workaround, that's what the policy intends for you to do.
Sun Jul 27 00:26:39 2008thaljef [...] cpan.org - Correspondence added
On Sun Mar 09 18:57:24 2008, clonezone wrote:
Show quoted text
> Elliot Shank via RT wrote:
> >
> > The workaround would be to use
> > ($y, my $x) = @_;
> > instead of
> > my $x;
> > ($y, $x) = @_;
>
> That's not a workaround, that's what the policy intends for you to do.
It isn't pretty, but I agree with Elliot on this. So I'm marking this
as 'resolved'.
Sun Jul 27 00:26:41 2008The RT System itself - Status changed from 'new' to 'open'
Sun Jul 27 00:26:44 2008thaljef [...] cpan.org - Status changed from 'open' to 'resolved'
RT for rt.cpan.org