Bug #33874 for Subtitles: Problem with shifting subtitles ahead on a certain time

Fri Mar 07 06:21:10 2008 ruivilela [...] di.uminho.pt - Ticket created

Subject:	Problem with shifting subtitles ahead on a certain time
Date:	Fri, 07 Mar 2008 11:20:41 +0000
To:	bug-Subtitles [...] rt.cpan.org
From:	Rui Vilela <ruivilela [...] di.uminho.pt>

Subtitles 1.0 I'm doing some time shift on a srt file that look like this I made before $ subs -i -b 30 katyn.srt It worked. But now: example: 492 01:07:59,600 --> 01:08:06,800 "Que o sangue polaco aqui derramado se torne garantia do renascimento da nossa pátria livre!"" 493 01:08:28,600 --> 01:08:29,200 O quê? 494 01:08:30,000 --> 01:08:35,800 Isto é mentira! Isto é mentira! O senhor ouviu? $ subs -i -p 1:08:28 +3 katyn.srt Use of uninitialized value in length at /usr/bin/subs line 230. result: 492 1551:45:32,267 --> 1554:29:51,467 "Que o sangue polaco aqui derramado se torne garantia do renascimento da nossa pátria livre!"" 493 1562:47:22,933 --> 1563:01:04,533 O quê? 494 1563:19:20,000 --> 1565:31:42,133 Isto é mentira! Isto é mentira! O senhor ouviu? Taking out the plus sign will not give any warning. Regards

Message body is not shown because sender requested not to inline it.

Fri Mar 07 06:39:17 2008 KARASIK [...] cpan.org - Correspondence added

Thanks, fixed! Apply the patch below to fix the problem: --- subs 12 Nov 2007 06:06:51 -0000 1.14 +++ subs 7 Mar 2008 11:35:39 -0000 @@ -215,7 +215,7 @@ my ( $p1, $p2) = @$_; my ( $s1, $s2); $s1 = (($p1 =~ s/^([-+])//) ? $1 : ''); - $s2 = (($p2 =~ s/^([-+])//) ? $2 : ''); + $s2 = (($p2 =~ s/^([-+])//) ? $1 : ''); my $t = $dest-> parse_time( $p1); die "Cannot parse time `$s1$p1'\n" unless defined $t; $p1 = $t;

Fri Mar 07 06:39:19 2008 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 07 06:39:19 2008 KARASIK [...] cpan.org - Status changed from 'open' to 'resolved'