Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 33813
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: cberry [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] cd.t expects unix syntax
The attached makes cd.t expect whatever the local catdir gives you for directory syntax instead of assuming some/dir will always be in unix syntax on every platform. It corrects a test failure with maint-5.8@33430 (soon to be 5.8.9) on VMS. 5.10.0 and blead have been passing even without this patch, but blead still passes after it.
Subject: cdsomedir.patch.txt
--- lib/ExtUtils/t/cd.t;-0 Tue Mar 4 07:06:51 2008 +++ lib/ExtUtils/t/cd.t Tue Mar 4 18:32:39 2008 @@ -17,7 +17,8 @@ use File::Spec; use Test::More tests => 4; -my @cd_args = ("some/dir", "command1", "command2"); +my $some_dir = File::Spec->catdir('some','dir'); +my @cd_args = ($some_dir, "command1", "command2"); { package Test::MM_Win32; @@ -33,7 +34,7 @@ my @cd_args = ("some/dir", "command1", " my $expected_updir = File::Spec->catdir(@dirs); ::is $mm->cd(@cd_args), -qq{cd some/dir +qq{cd $some_dir command1 command2 cd $expected_updir}; @@ -43,15 +44,15 @@ qq{cd some/dir local *make = sub { "dmake" }; ::is $mm->cd(@cd_args), -q{cd some/dir && command1 - cd some/dir && command2}; +qq{cd $some_dir && command1 + cd $some_dir && command2}; } } { is +ExtUtils::MM_Unix->cd(@cd_args), -q{cd some/dir && command1 - cd some/dir && command2}; +qq{cd $some_dir && command1 + cd $some_dir && command2}; } SKIP: {
Ping. Any chance of getting this applied and into a release?
Sorry for the delay. It's been fixed. Is this the only outstanding issue in MakeMaker for VMS? If so, I'll push a release.