Bug #33711 for Readonly-XS: test.t failing in perl 5.10

Fri Feb 29 13:01:52 2008 dillman [...] ria.buffalo.edu - Ticket created

Subject:	test.t failing in perl 5.10
Date:	Fri, 29 Feb 2008 13:01:28 -0500
To:	bug-Readonly-XS [...] rt.cpan.org
From:	dillman [...] ria.buffalo.edu

In perl 5.10 'use warnings' no longer loads Carp.
Adding 'use Carp' to test.t allows the test script to work.

Thomas J. Dillman
Research Institute on Addictions
1021 Main Street, Buffalo, NY 14203

Sat Mar 01 06:28:24 2008 ANDK [...] cpan.org - Correspondence added

I have a patch for that on CPAN: ANDK/patches/Readonly-XS-1.04-ANDK-01.patch.gz

Sat Mar 01 06:28:25 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Oct 18 16:11:52 2008 mschwern [...] cpan.org - Correspondence added

Hi Eric, Could you please apply Andreas' patch and cut a new release? This will get Readonly::XS working again on 5.10.0. --- XS.pm 2005-12-06 07:04:00.000000000 +0100 +++ XS.pm 2007-11-18 23:00:29.000000000 +0100 @@ -33,7 +33,7 @@ BEGIN if ($MAGIC_COOKIE ne "Do NOT use or require Readonly::XS unless you're me.") { require Carp; - Carp::croak "Readonly::XS is not a standalone module. You should not use it directly."; + Carp::croak("Readonly::XS is not a standalone module. You should not use it directly."); } }

Thu Jan 01 21:06:38 2009 apeiron [...] cpan.org - Correspondence added

On Sat Oct 18 16:11:52 2008, MSCHWERN wrote: Show quoted text

> Hi Eric, > Could you please apply Andreas' patch and cut a new release? This will > get Readonly::XS working again on 5.10.0. > > --- XS.pm 2005-12-06 07:04:00.000000000 +0100 > +++ XS.pm 2007-11-18 23:00:29.000000000 +0100 > @@ -33,7 +33,7 @@ BEGIN > if ($MAGIC_COOKIE ne "Do NOT use or require Readonly::XS unless > you're me.") > { > require Carp; > - Carp::croak "Readonly::XS is not a standalone module. You > should not use it directly."; > + Carp::croak("Readonly::XS is not a standalone module. You > should not use it directly."); > } > } >

I just deduced the same fix myself on my 5.10 and it does indeed fix the problem. Came here to find the bug and patch already in rt. Pinging as a reminder. :)