Skip Menu |

This queue is for tickets about the Net-DNS-ToolKit CPAN distribution.

Report information
The Basics
Id: 33617
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Net-DNS-ToolKit

People
Owner: Nobody in particular
Requestors: rafal [...] krypa.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.35
Fixed in: (no value)



Subject: newhead() ignores $arcount argument when $nscount = 0
1: sub newhead { 2: my($bp,$id,$flags,$qdcount,$ancount,$nscount,$arcount) = @_; 3: return undef unless ref $bp; 4: return undef unless defined $id; 5: $qdcount = 0 unless $qdcount; 6: $ancount = 0 unless $ancount; 7: $nscount = 0 unless $nscount; 8: $arcount = 0 unless $nscount; 9: $$bp = pack("n n n n n n",$id,$flags,$qdcount,$ancount,$nscount,$arcount); 10: return NS_HFIXEDSZ; 11: } On 8th line there should be of course '$arcount = 0 unless $arcount;'
From: michael [...] bizsystems.com
On Wed Feb 27 06:38:04 2008, Iceberg wrote: Show quoted text
> 1: sub newhead { > 2: my($bp,$id,$flags,$qdcount,$ancount,$nscount,$arcount) = @_; > 3: return undef unless ref $bp; > 4: return undef unless defined $id; > 5: $qdcount = 0 unless $qdcount; > 6: $ancount = 0 unless $ancount; > 7: $nscount = 0 unless $nscount; > 8: $arcount = 0 unless $nscount; > 9: $$bp = pack("n n n n n > n",$id,$flags,$qdcount,$ancount,$nscount,$arcount); > 10: return NS_HFIXEDSZ; > 11: } > > On 8th line there should be of course '$arcount = 0 unless $arcount;'
Fixed in release 0.36 Thanks to Rafal Krypa
fixed in release 0.36 Thanks to Rafal Krypa
Subject: Re: [rt.cpan.org #33617] newhead() ignores $arcount argument when $nscount = 0
Date: Wed, 27 Feb 2008 11:50:35 -0800
To: bug-Net-DNS-ToolKit [...] rt.cpan.org
From: michael [...] insulin-pumpers.org
Show quoted text
> > Wed Feb 27 06:38:04 2008: Request 33617 was acted upon. > Transaction: Ticket created by Iceberg > Queue: Net-DNS-ToolKit > Subject: newhead() ignores $arcount argument when $nscount = 0 > Broken in: 0.35 > Severity: Normal > Owner: Nobody > Requestors: mail@iceberg.pl > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=33617 > > > > 1: sub newhead { > 2: my($bp,$id,$flags,$qdcount,$ancount,$nscount,$arcount) = @_; 3: > return undef unless ref $bp; 4: return undef unless defined $id; > 5: $qdcount = 0 unless $qdcount; 6: $ancount = 0 unless $ancount; > 7: $nscount = 0 unless $nscount; 8: $arcount = 0 unless $nscount; > 9: $$bp = pack("n n n n n > n",$id,$flags,$qdcount,$ancount,$nscount,$arcount); > 10: return NS_HFIXEDSZ; > 11: } > > On 8th line there should be of course '$arcount = 0 unless $arcount;'
ahhh.... Thank You, I will fix and release today. Best regards, Michael
should be resolved by last release some time ago.