Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 33532
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: [patch] don't complain about architecture mismatch on win32
In some situations on Win32, the "pthinks" path can be a Windows "short" path whereas the "cthinks" path can be a "long" path. This patch normalizes both before comparison on Win32. --- MakeMaker.pm.orig Fri Feb 22 23:25:52 2008 +++ MakeMaker.pm Sat Feb 23 07:03:39 2008 @@ -34,6 +34,8 @@ my $Is_VMS = $^O eq 'VMS'; my $Is_Win32 = $^O eq 'MSWin32'; +if ( $Is_Win32 ) { require Win32 } + # Our filename for diagnostic and debugging purposes. More reliable # than %INC (think caseless filesystems) $Filename = __FILE__; @@ -534,7 +536,8 @@ my($cthinks) = $self->catfile($Config{'archlibexp'},'Config.pm'); $pthinks = VMS::Filespec::vmsify($pthinks) if $Is_VMS; if ($pthinks ne $cthinks && - !($Is_Win32 and lc($pthinks) eq lc($cthinks))) { + !($Is_Win32 and lc(Win32::GetShortPath($pthinks)) + eq lc(Win32::GetShortPath($cthinks)))) { print "Have $pthinks expected $cthinks\n"; if ($Is_Win32) { $pthinks =~ s![/\\]Config\.pm$!!i; $pthinks =~ s!.*[/\\]!!;
Applied, with a bunch of refactoring to split out the Windows and VMS bits.
Whoops. Output from 'C:\Perl\bin\perl.exe Makefile.PL': Checking if your kit is complete... Looks good Undefined subroutine &Win32::GetShortPath called at lib/ExtUtils/MM_Win32.pm line 417. http://www.nntp.perl.org/group/perl.cpan.testers/2009/04/msg3670937.html Could you investigate and patch that up please, David?
On Sun Apr 12 21:42:13 2009, MSCHWERN wrote: Show quoted text
> Undefined subroutine &Win32::GetShortPath called at > lib/ExtUtils/MM_Win32.pm line 417. > > http://www.nntp.perl.org/group/perl.cpan.testers/2009/04/msg3670937.html > > Could you investigate and patch that up please, David?
My bad. The function is GetShortPathName -- but when I add that to the MM master on github, I get other failures, so I'll see what I can do and send you a pull request when I'm done.
Should be fixed now.