Bug #33530 for Devel-Size: Not compiling under bleadperl

On Monday 14 April 2008 15:44:32 Reini Urban via RT wrote: Show quoted text
Thanx for the patch, but I will not apply the change from "thing" to "sv", renaming this variable doesn't add enough value (from my POV) to justify touching a lot of code. ATM I am happy Devel::Size works. Release of v0.70 will be done shortly, thanx again. Best wishes, Tels -- Signed on Mon Apr 14 17:19:32 2008 with key 0x93B84C15. Get one of my photo posters: http://bloodgate.com/posters PGP key on http://bloodgate.com/tels.asc or per email. This email violates U.S. patent #4,197,590: for (x = 0; x < widht; x++) { for (y = 0; y < height; y++) { setPixel (x+xm, y+ym, getPixel(x+xm,y+ym) ^ getCursorPixel(x,y); } }

On Saturday 23 August 2008 06:21:00 Andreas Koenig via RT wrote: Show quoted text
Five minutes ago :) Just pushed the well-aged v0.70 from my HD to PAUSE. Briefly tested to compile and pass the tests on v5.8.8 and v5.10.0 - but I am not sure if it really fixes all issues. I believe there is still an unresolved segfault somewhere hidden. Tests and patches welcome :) Tels PS: Sorry for the delay... :( -- Signed on Sat Aug 23 09:20:33 2008 with key 0x93B84C15. Get one of my photo posters: http://bloodgate.com/posters PGP key on http://bloodgate.com/tels.asc or per email. "We're looking at a future where only the very largest companies will be able to implement software, and it will technically be illegal for other people to do so." -- Bruce Perens, 2004-01-23

On Saturday 23 August 2008 19:54:35 Andreas Koenig via RT wrote: Show quoted text
Unfortunately I neither have the time nor expertise to look into that. But I'll gladly apply any patches and release new versions. All the best, Tels -- Signed on Sun Aug 24 00:19:04 2008 with key 0x93B84C15. Get one of my photo posters: http://bloodgate.com/posters PGP key on http://bloodgate.com/tels.asc or per email. "Un bon mot ne prouve rien." -- Voltaire

On Sunday 24 August 2008 06:03:44 Andreas Koenig via RT wrote: Show quoted text
It would really have helped if you had given me a host to that file, too :) Also, compressing the file with gzip twice was unnecessary :) Show quoted text
Oh, yeah, I remember now, that infamous patch that only should change about 4 lines, but changes the code all over by renaming a variable. Reini never responded to my request for a more localized change. :( So I rewrote the patch, hopefully fixing the error and not changing unrelated things and not dropping anything. There is one thing that I did not take in: - RETVAL = sv_size(sv, tracking_hash); ... + if (SvOK(sv)) + RETVAL = sv_size(sv, tracking_hash); That change causes a test in basic.t to fail under v5.8.8 and v5.10.0, because RETVAL was not set, resulting in garbage being returned. If that change is nec. for 5.11, someone please drop me a note (preferable with a small patch :) Here is a copy to a pre-release package: http://www.bloodgate.com/perl/packages/devel/Devel-Size-0.71.tar.gz Would be good if someone could test that with blead as I don't have it here. All the best, Tels -- Signed on Sun Aug 24 10:15:09 2008 with key 0x93B84C15. View my photo gallery: http://bloodgate.com/photos PGP key on http://bloodgate.com/tels.asc or per email. Like my code? Want to hire me to write some code for you? Send email!

On Sunday 24 August 2008 14:06:57 (Andreas J. Koenig) via RT wrote: Show quoted text
The problem is that I can't click the original line as it is not a valid URL. So I did got to several hosts like "search.cpan.org", "pause.org" etc etc., appended that line and it and was never right or valid. In the end I browsed to search.cpan.org, clicked on AUTHORS and browsed until I found your page, then clicked on your CPAN directory, then used CTRL-F in my browser to finally find the file. That is an awful lot of work just to download one file. You could also just have attached it on your email :) (I am not that familiar with CPAN as you are, so excuse my ignorance.) Show quoted text
I tried it with wget and the FTP URL above and it was only once compressed. However, the version I downloaded with Firefox I uncompressed with gzip and afterwards the file was still gzipped (which confused me, because mc transparently ungzips the file before displaying, while vi does not, ending up in garbage). Can no longer tell if that was a browser issue, or my mistake in uncompressing the file, so it was probably "tels had not enough coffee yet" :) Show quoted text
Inserting that line does cause indeed test failures here, so I am not sure how that came into the patch. Show quoted text
Cool, I upload v0.71 to CPAN then. One more thing, I believe it will report incorrect numbers on on bleedperl less than the COP patch (33656), but it might be that the testsuite won't catch this. (It usually only tests sizes relativ to each other, as the exact size on a specific architecture/perl version isn't known in advance). Not sure if this issue is worth doing anything about, because there will be only little people who use bleedperl between 5.10.0 and @33656 :) All the best, Tels -- Signed on Sun Aug 24 14:39:17 2008 with key 0x93B84C15. View my photo gallery: http://bloodgate.com/photos PGP key on http://bloodgate.com/tels.asc or per email. Marketing lesson #1: The synergy of the result driven leverage can *never* incentivize a paradigm shift. -- Walterk (124748) on 2004-01-16 at /.