Bug #33472 for POE-Component-IRC: PoCo::IRC should trim long lines

Wed Feb 20 17:14:14 2008 martin.ferrari [...] gmail.com - Ticket created

Subject:	PoCo::IRC should trim long lines
Date:	Wed, 20 Feb 2008 16:10:44 -0200
To:	bug-POE-Component-IRC [...] rt.cpan.org
From:	"Martín Ferrari" <martin.ferrari [...] gmail.com>

Hi, Today I discovered that a commit notification bot I wrote with PoCo::IRC wes getting kicked out of the server with a "Request too long" message. Inspection revealed that the PRIVMSG it sent to the channel was causing the kick because the raw command was longer than 512 bytes, including \r\n. It seems that my private irc server is one of the few to enforce the limit, but that's what the rfc says, so it'd be nice if your module did check it. Thanks for the nice and useful code! -- Martín Ferrari

Sat Feb 23 04:47:30 2008 BINGOS [...] cpan.org - Correspondence added 10 min

Hi, Thanks for the ticket. POE::Component::IRC will now trim long lines as per the RFC. This behaviour will be available in the CPAN release 4.70 Cheers, Chris 'BinGOs' Williams

Sat Feb 23 04:47:31 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Feb 23 04:47:32 2008 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Feb 23 04:47:33 2008 BINGOS [...] cpan.org - Given to BINGOS

Sat Feb 23 04:52:31 2008 BINGOS [...] cpan.org - Correspondence added

From:

BINGOS [...] cpan.org

On Wed Feb 20 17:14:14 2008, martin.ferrari@gmail.com wrote: Show quoted text

> Hi, > > Today I discovered that a commit notification bot I wrote with > PoCo::IRC wes getting kicked out of the server with a "Request too > long" message. Inspection revealed that the PRIVMSG it sent to the > channel was causing the kick because the raw command was longer than > 512 bytes, including \r\n. It seems that my private irc server is one > of the few to enforce the limit, but that's what the rfc says, so it'd > be nice if your module did check it. > > Thanks for the nice and useful code! >

Sorry I meant to say 5.70 instead of 4.70 Doh.

Sat Feb 23 04:52:32 2008 The RT System itself - Status changed from 'resolved' to 'open'

Sat Feb 23 04:53:42 2008 BINGOS [...] cpan.org - Correspondence added 1 min

Closing ticket. Again. I suck at this.

Sat Feb 23 04:53:44 2008 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Feb 23 09:43:29 2008 martin.ferrari [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #33472] PoCo::IRC should trim long lines
Date:	Sat, 23 Feb 2008 12:41:34 -0200
To:	bug-POE-Component-IRC [...] rt.cpan.org
From:	"Martín Ferrari" <martin.ferrari [...] gmail.com>

On Sat, Feb 23, 2008 at 7:47 AM, BINGOS via RT <bug-POE-Component-IRC@rt.cpan.org> wrote: Show quoted text

> Thanks for the ticket. POE::Component::IRC will now trim long lines as per > the RFC. > > This behaviour will be available in the CPAN release 4.70

Thanks Chris! -- Martín Ferrari

Sat Feb 23 09:43:31 2008 The RT System itself - Status changed from 'resolved' to 'open'

Mon Mar 03 06:11:57 2008 BINGOS [...] cpan.org - Correspondence added 5 min

4.70 has been released.

Mon Mar 03 06:11:59 2008 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Mar 16 21:12:49 2008 martin.ferrari [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #33472] PoCo::IRC should trim long lines
Date:	Sun, 16 Mar 2008 22:12:32 -0300
To:	bug-POE-Component-IRC [...] rt.cpan.org
From:	"Martín Ferrari" <martin.ferrari [...] gmail.com>

On Mon, Mar 3, 2008 at 8:11 AM, BINGOS via RT <bug-POE-Component-IRC@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=33472 > > > 4.70 has been released.

Sorry for nagging again (and RT will surely reopen the bug). I'm upgrading the version of PoCo::IRC in Debian and saw that you added a long line ($long variable) for testing this in t/1_filter_compat.t, but don't actually use it. Just pointing this out because it looks like you forgot to complete the test. Thanks once again. -- Martín Ferrari

Sun Mar 16 21:12:50 2008 The RT System itself - Status changed from 'resolved' to 'open'

Mon Mar 31 01:16:12 2008 hinrik.sig [...] gmail.com - Correspondence added

Thanks for the pointer. The test suite will be revamped soon, adding tests for this feature, among other things.

Mon Mar 31 01:16:14 2008 hinrik.sig [...] gmail.com - Status changed from 'open' to 'resolved'

Mon Mar 31 01:16:35 2008 hinrik.sig [...] gmail.com - Stolen from BINGOS