Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Notify CPAN distribution.

Report information
The Basics
Id: 33454
Status: resolved
Priority: 0/
Queue: SVN-Notify

People
Owner: Nobody in particular
Requestors: martin [...] unicorn.tv
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.70



Subject: [PATCH] Notify.pm sanity check fix
Somewhere between r3438 and r3447 some additional sanity checking was added, causing the tool to fail claiming sendmail was not found, before it looks for it. Attached patch moves the sanity check later down and fixes the issue.
Subject: myfix.diff
Index: lib/SVN/Notify.pm =================================================================== --- lib/SVN/Notify.pm (revision 3447) +++ lib/SVN/Notify.pm (working copy) @@ -701,8 +701,6 @@ die qq{Missing required "to", "to_regex_map", or "to_email_map" parameter} unless @{ $params{to} } || $params{to_regex_map} || $params{to_email_map}; - die qq{Cannot find sendmail and no "smtp" parameter specified} - unless $params{sendmail} || $params{smtp}; # Set up default values. $params{svnlook} ||= $ENV{SVNLOOK} || $class->find_exe('svnlook'); @@ -715,6 +713,9 @@ $params{sendmail} ||= $ENV{SENDMAIL} || $class->find_exe('sendmail') unless $params{smtp}; + die qq{Cannot find sendmail and no "smtp" parameter specified} + unless $params{sendmail} || $params{smtp}; + # Set up the environment language. if ( $params{language} && !$ENV{LANG} ) { ( my $lang_country = $params{language} ) =~ s/_/-/g;
Subject: Re: [rt.cpan.org #33454] [PATCH] Notify.pm sanity check fix
Date: Wed, 20 Feb 2008 12:19:19 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: "David E. Wheeler" <david [...] justatheory.com>
On Feb 20, 2008, at 01:09, Martin Lindhe via RT wrote: Show quoted text
> Somewhere between r3438 and r3447 some additional sanity checking was > added, causing the tool to fail claiming sendmail was not found, > before > it looks for it. Attached patch moves the sanity check later down and > fixes the issue.
Duh. That was dumb of me. Thanks for the catch. Applied in r3449. Best, David