Bug #33429 for DBD-Pg: Depends on version.pm but does not list it as a dependency

Tue Feb 19 05:41:14 2008 CLAESJAC [...] cpan.org - Ticket created

Subject:

Depends on version.pm but does not list it as a dependency

perl prior than 5.10 does not ship with version.pm which causes the Makefile.PL to fail since it uses that module. this causes installation of Perl 5.6.2 to fail (and 5.8.x if version.pm is not installed). There is little reason that the Makefile.PL itself should actually need to use version objects as introduced by #33206. Instead it should use the old string version and output version in the PREREQ_PM option to EU::MMs WriteMakefile.

Thu Feb 21 11:20:54 2008 greg [...] turnstep.com - Fixed in 2.1.3 added

Thu Feb 21 11:20:55 2008 greg [...] turnstep.com - Status changed from 'new' to 'resolved'

Thu Feb 21 11:39:59 2008 claes [...] versed.se - Correspondence added

Subject:	Re: [rt.cpan.org #33429] Resolved: Depends on version.pm but does not list it as a dependency
Date:	Thu, 21 Feb 2008 17:39:37 +0100
To:	bug-DBD-Pg [...] rt.cpan.org
From:	Claes Jakobsson <claes [...] versed.se>

This bug is still not resolved completely. It does list version in META.yml but Makefile.PL still depends on it which makes cpan shell go pfft on stock 5.6.2 can't locate version.pm in @INC (@INC contains: /opt/perl/5.6.2/lib/ 5.6.2/darwin /opt/perl/5.6.2/lib/5.6.2 /opt/perl/5.6.2/lib/site_perl/ 5.6.2/darwin /opt/perl/5.6.2/lib/site_perl/5.6.2 /opt/perl/5.6.2/lib/ site_perl .) at Makefile.PL line 9. BEGIN failed--compilation aborted at Makefile.PL line 9. No such signal: SIGALRM at /opt/perl/5.6.2/lib/5.6.2/CPAN.pm line 4571, <FIN> line 1. Running make test Make had some problems, maybe interrupted? Won't test Running make install Make had some problems, maybe interrupted? Won't install --- Claes Jakobsson | claes@versed.se | +46-702-823327 Versed Solutions | http://www.versed.se/

Thu Feb 21 11:40:00 2008 The RT System itself - Status changed from 'resolved' to 'open'

Fri Feb 22 10:01:29 2008 slanning [...] cpan.org - Correspondence added

From:

slanning [...] cpan.org

Furthermore, t/00basic.t fails because qv// puts a 'v' in front of the string. This is how I got it working: # use version; our $VERSION = qv('2.1.3'); our $VERSION = '2.1.3';

Fri Feb 22 10:06:49 2008 greg [...] turnstep.com - Correspondence added

From:

greg [...] turnstep.com

Which version did you try this on? version is listed as a prereq in both META.yml and Makefile.PL as of 2.1.2. If this was on a version less than that, please try again. Otherwise, I'm open to ideas. :)

Fri Feb 22 10:25:20 2008 claes [...] versed.se - Correspondence added

Subject:	Re: [rt.cpan.org #33429] Depends on version.pm but does not list it as a dependency
Date:	Fri, 22 Feb 2008 16:24:42 +0100
To:	bug-DBD-Pg [...] rt.cpan.org
From:	Claes Jakobsson <claes [...] versed.se>

On 22 feb 2008, at 16.06, Greg Sabino Mullane via RT wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=33429 > > > Which version did you try this on? version is listed as a prereq in > both > META.yml and Makefile.PL as of 2.1.2. If this was on a version less > than > that, please try again. Otherwise, I'm open to ideas. :)

This was 2.1.3 straight from CPAN on a fresh perl 5.6.2, ie one with the stock CPAN.pm (1.59_54). It looks like it does not follow what META.yml says and relies on parsing the output from Makefile.PL (ie, Warning: prerequisite Object::Tiny 0 not found) to find dependencies. I think an easy and workable fix would be to not use version.pm in the Makefile.PL itself and treat the $VERSION there as a string since it's only used in a regexp to check if it's a devel-version and the real package version is declared using VERSION_FROM => "Pg.pm". It should still continue to to list version as a dependency in PREREQ_PM tho. /Claes --- Claes Jakobsson | claes@versed.se | +46-702-823327 Versed Solutions | http://www.versed.se/

Sun Feb 24 21:03:00 2008 greg [...] turnstep.com - Correspondence added

Thanks, will remove version.pm from Makefile.PL in the next version.

Sat Mar 01 21:12:19 2008 greg [...] turnstep.com - Fixed in 2.2.0 added

Sat Mar 01 21:12:20 2008 greg [...] turnstep.com - Fixed in 2.1.3 deleted

Sat Mar 01 21:12:20 2008 greg [...] turnstep.com - Status changed from 'open' to 'resolved'