Subject: | Net::LDAP::LDIF Observation |
Date: | Thu, 14 Feb 2008 09:55:38 -0500 |
To: | <bug-perl-ldap [...] rt.cpan.org> |
From: | "David Newman" <DNewman [...] synacor.com> |
While going through the source code for Net::LDAP:LDIF I noticed the
following that the author may want to address:
Module Net::LDAP::LDIF
Module Version .37
Web Page: http://search.cpan.org/~gbarr/perl-ldap/lib/Net/LDAP/LDIF.pod
Observations:
On line 404 in the _Write_Attr method the if statement doesn't do
anything because of semicolon directly after the parenthesis.
On line 440 in the _Write_Dn methos the if statement doesn't do anything
because of semicolon directly after the parenthesis.
Perhaps there was an intention.
I was using the module to learn how to properly handled special
characters for an LDIF file. I didn't see any conversion handling for
sources that are not utf8 and/or not properly handled for special
characters.
David Newman
Migration Engineer
Synacor Inc.
40 La Riviere Drive Suite 300
Buffalo, NY 14202
716-362-3737
www.synacor.com