Skip Menu |

This queue is for tickets about the perl-ldap CPAN distribution.

Report information
The Basics
Id: 33257
Status: resolved
Priority: 0/
Queue: perl-ldap

People
Owner: Nobody in particular
Requestors: DNewman [...] synacor.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Net::LDAP::LDIF Observation
Date: Thu, 14 Feb 2008 09:55:38 -0500
To: <bug-perl-ldap [...] rt.cpan.org>
From: "David Newman" <DNewman [...] synacor.com>
While going through the source code for Net::LDAP:LDIF I noticed the following that the author may want to address: Module Net::LDAP::LDIF Module Version .37 Web Page: http://search.cpan.org/~gbarr/perl-ldap/lib/Net/LDAP/LDIF.pod Observations: On line 404 in the _Write_Attr method the if statement doesn't do anything because of semicolon directly after the parenthesis. On line 440 in the _Write_Dn methos the if statement doesn't do anything because of semicolon directly after the parenthesis. Perhaps there was an intention. I was using the module to learn how to properly handled special characters for an LDIF file. I didn't see any conversion handling for sources that are not utf8 and/or not properly handled for special characters. David Newman Migration Engineer Synacor Inc. 40 La Riviere Drive Suite 300 Buffalo, NY 14202 716-362-3737 www.synacor.com
Subject: Re: [rt.cpan.org #33257] Net::LDAP::LDIF Observation
Date: Thu, 14 Feb 2008 18:44:30 -0600
To: bug-perl-ldap [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
On Feb 14, 2008, at 8:56 AM, David Newman via RT wrote: Show quoted text
> On line 404 in the _Write_Attr method the if statement doesn't do > anything because of semicolon directly after the parenthesis.
Yes it does. The if is a statement modifier for the line before Show quoted text
> On line 440 in the _Write_Dn methos the if statement doesn't do > anything > because of semicolon directly after the parenthesis.
Same, it is a statement modifier Show quoted text
> Perhaps there was an intention. > > I was using the module to learn how to properly handled special > characters for an LDIF file. I didn't see any conversion handling for > sources that are not utf8 and/or not properly handled for special > characters.
LDIF is defined as an ASCII format, so there would be no such handling. Any value that contains non-ascii bytes will be base64 encoded, but there is nothing in the LDIF spec that states how to denote that a value it binary or utf8, for that you would have to look at the field definition in your LDAP schema. Graham.