| Subject: | 2.0.0_9: Build break when compiling with 'gcc -ansi' |
In 2.0.0_9, the dbdimp.c file contains a few C++-style comments. When
compiling via gcc with the -ansi option, C++-style comments aren't
allowed in C files. Please convert to /* */ comments.
Patch attached.
Also, 2.0.0 isn't currently an option for the "Broken in" field when
submitting bugs. Might want to fix that. :)
Environment:
DBD::Pg version: 2.0.0_9
perl -v: This is perl, v5.8.5 built for x86_64-linux-ld
uname -a: Linux dev-linux06 2.6.9-42.ELsmp #1 SMP Tue Aug 15 10:35:26
BST 2006 x86_64 x86_64 x86_64 GNU/Linux
gcc --version: gcc (GCC) 3.4.6 20060404 (Red Hat 3.4.6-9)
| Subject: | DBD-Pg-comment-fix.patch |
928c928
< //fieldname = newSVpv(PQfname(imp_sth->result, fields),0);
---
> /* fieldname = newSVpv(PQfname(imp_sth->result, fields),0); */
1098c1098
< // unsigned int newval = SvTRUE(valuesv);
---
> /* unsigned int newval = SvTRUE(valuesv); */
2500c2500
< imp_dbh->async_sth = NULL; // Needed?
---
> imp_dbh->async_sth = NULL; /* Needed? */