| Subject: | [PATCH] Exporter is not needed |
| Date: | Fri, 8 Feb 2008 17:41:01 -0200 |
| To: | "Alex Bowley" <kilinrax [...] cpan.org>, bug-HTML-Strip [...] rt.cpan.org |
| From: | "Adriano Ferreira" <a.r.ferreira [...] gmail.com> |
The following patch removes the dependency to Exporter, which is not
used after all.
All tests passes without need for changes. Now without Exporter's overhead.
This change is coherent with the fact that this is a pure OO module,
which does not need to export any symbol, because all functionality is
available via methods in instances of the class HTML::Strip.
Kind regards,
Adriano Ferreira
diff -ru HTML-Strip-1.06/Changes HTML-Strip/Changes
--- HTML-Strip-1.06/Changes 2006-02-10 09:19:17.000000000 -0200
+++ HTML-Strip/Changes 2008-02-08 17:35:21.000000000 -0200
@@ -1,5 +1,8 @@
Revision history for Perl extension HTML::Strip.
+?
+ - Exporter was never needed
+
1.06 Fri Feb 10 11:18:35 2006
- documented 'set_decode_entities' method
diff -ru HTML-Strip-1.06/Strip.pm HTML-Strip/Strip.pm
--- HTML-Strip-1.06/Strip.pm 2006-02-10 09:18:32.000000000 -0200
+++ HTML-Strip/Strip.pm 2008-02-08 17:35:28.000000000 -0200
@@ -6,24 +6,9 @@
use Carp qw( carp croak );
-require Exporter;
require DynaLoader;
-our @ISA = qw(Exporter DynaLoader);
-
-# Items to export into callers namespace by default. Note: do not export
-# names by default without a very good reason. Use EXPORT_OK instead.
-# Do not simply export all your public functions/methods/constants.
-
-# This allows declaration use HTML::Strip ':all';
-# If you do not need this, moving things directly into @EXPORT or @EXPORT_OK
-# will save memory.
-our %EXPORT_TAGS = ( 'all' => [ qw(
- ) ] );
-
-our @EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
-
-our @EXPORT = qw();
+our @ISA = qw(DynaLoader);
our $VERSION = '1.06';
Message body is not shown because sender requested not to inline it.