Bug #32957 for Test-JSON: Test failure when only JSON::Syck and JSON::Any are installed

Wed Feb 06 02:16:04 2008 ANDK [...] cpan.org - Ticket created

CC:	PERIGRIN [...] cpan.org
Subject:	Test failure when only JSON::Syck and JSON::Any are installed

Seemingly random test results revealed that whenever the only installed JSON implementation is JSON::Syck 0.27, then one test in Test::JSON fails. This may be regarded as a bug in JSON::Any, I'm not sure. Reporting here and CC'ing the author of JSON::Any. Best,

Mon Jun 29 14:30:14 2009 ovid [...] cpan.org - Correspondence added

On Wed Feb 06 02:16:04 2008, ANDK wrote: Show quoted text

> Seemingly random test results revealed that whenever the only installed > JSON implementation is JSON::Syck 0.27, then one test in Test::JSON fails. > > This may be regarded as a bug in JSON::Any, I'm not sure. Reporting here > and CC'ing the author of JSON::Any. > > Best,

By the way, is this bug still around? I think it was not my bug, but I'm unsure. There's not enough information for me to reproduce this, but I don't want to close it without being sure. Cheers, Ovid

Mon Jun 29 14:30:16 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 29 14:49:10 2009 chris [...] prather.org - Correspondence added

Subject:	Re: [rt.cpan.org #32957] Test failure when only JSON::Syck and JSON::Any are installed
Date:	Mon, 29 Jun 2009 14:48:45 -0400
To:	bug-Test-JSON [...] rt.cpan.org
From:	Chris Prather <perigrin [...] gmail.com>

On Mon, Jun 29, 2009 at 2:30 PM, Curtis 'Ovid' Poe via RT<bug-Test-JSON@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=32957 > > > On Wed Feb 06 02:16:04 2008, ANDK wrote:

>> Seemingly random test results revealed that whenever the only installed >> JSON implementation is JSON::Syck 0.27, then one test in Test::JSON fails. >> >> This may be regarded as a bug in JSON::Any, I'm not sure. Reporting here >> and CC'ing the author of JSON::Any. >> >> Best,

> > By the way, is this bug still around? I think it was not my bug, but > I'm unsure. There's not enough information for me to reproduce this, > but I don't want to close it without being sure. > > Cheers, > Ovid >

I don't have an active bug for it in JSON::Any's RT queue. If someone can get me something reproducible I'll happily take a whack at it. -Chris

Tue Jun 30 00:09:08 2009 ANDK [...] cpan.org - Correspondence added

Executive Summary: yes I can reproduce what the bugreport stated in its first paragraph. I still have not made up my mind whether it's a bug in JSON::Any or in Test::JSON. Your call. Long version: I took a random perl and removed one after the other potential JSON packages: mv /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/JSON.pm{,.hide} mv /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/x86_64-linux-ld/JSON/DWIW.pm{,.hide} mv /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/JSON/PP.pm{,.hide} mv /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/x86_64-linux-ld/JSON/XS.pm{,.hide} So now only JSON::Syck was left over and I could finish my investigation by running test on Test::JSON as in the following: cpan[15]> m JSON::Syck Module id = JSON::Syck CPAN_USERID AUDREYT (Audrey Tang <cpan@audreyt.org>) CPAN_VERSION 0.30 CPAN_FILE A/AU/AUDREYT/YAML-Syck-1.07.tar.gz UPLOAD_DATE 2009-04-25 MANPAGE JSON::Syck - JSON is YAML (but consider using JSON::XS instead!) INST_FILE /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/x86_64-linux-ld/JSON/Syck.pm INST_VERSION 0.30 cpan[16]> test Test::JSON Running test for module 'Test::JSON' Running Build for O/OV/OVID/Test-JSON-0.07.tar.gz Prepending /home/sand/.cpan/build/File-LocalizeNewlines-1.11-8JICKC/blib/arch /home/sand/.cpan/build/File-LocalizeNewlines-1.11-8JICKC/blib/lib to PERL5LIB for 'get' Has already been unwrapped into directory /home/sand/.cpan/build/Test-JSON-0.07-XQN8AG Prepending /home/sand/.cpan/build/File-LocalizeNewlines-1.11-8JICKC/blib/arch /home/sand/.cpan/build/File-LocalizeNewlines-1.11-8JICKC/blib/lib to PERL5LIB for 'make' Has already been made Prepending /home/sand/.cpan/build/File-LocalizeNewlines-1.11-8JICKC/blib/arch /home/sand/.cpan/build/File-LocalizeNewlines-1.11-8JICKC/blib/lib to PERL5LIB for 'test' Running Build test # Failed test 'use Test::JSON;' # at t/00-load.t line 6. # Tried to use 'Test::JSON'. # Error: Couldn't find a JSON Package. at /home/sand/.cpan/build/Test-JSON-0.07-XQN8AG/blib/lib/Test/JSON.pm line 7 # BEGIN failed--compilation aborted at /home/sand/.cpan/build/Test-JSON-0.07-XQN8AG/blib/lib/Test/JSON.pm line 7. # Compilation failed in require at (eval 4) line 2. # BEGIN failed--compilation aborted at (eval 4) line 2. Use of uninitialized value $Test::JSON::VERSION in concatenation (.) or string at t/00-load.t line 9. # Testing Test::JSON , Perl 5.010000, /usr/local/perl-5.10-uld/bin/perl # Looks like you failed 1 test of 1. t/00-load.t ....... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Couldn't find a JSON Package. at /home/sand/.cpan/build/Test-JSON-0.07-XQN8AG/blib/lib/Test/JSON.pm line 7 BEGIN failed--compilation aborted at /home/sand/.cpan/build/Test-JSON-0.07-XQN8AG/blib/lib/Test/JSON.pm line 7. Compilation failed in require at t/10testjson.t line 4. BEGIN failed--compilation aborted at t/10testjson.t line 4. t/10testjson.t .... Dubious, test returned 2 (wstat 512, 0x200) No subtests run t/pod-coverage.t .. ok t/pod.t ........... ok Test Summary Report ------------------- t/00-load.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 t/10testjson.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=4, Tests=3, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.21 cusr 0.02 csys = 0.27 CPU) Result: FAIL Failed 2/4 test programs. 1/3 subtests failed. (./Build test exited with 65280) CPAN::Reporter: Test result is 'fail', One or more tests failed. CPAN::Reporter: preparing a CPAN Testers report for Test-JSON-0.07 CPAN::Reporter: this appears to be a duplicate report for the test phase: FAIL Test-JSON-0.07 x86_64-linux-ld 2.6.26-1-amd64 Test report will not be sent. OVID/Test-JSON-0.07.tar.gz ./Build test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports OVID/Test-JSON-0.07.tar.gz Failed during this command: OVID/Test-JSON-0.07.tar.gz : make_test NO Hope that helps. Please let me know if you need further details about the involved perl or whatever. Best,

Tue Jun 30 01:43:41 2009 chris [...] prather.org - Correspondence added

Subject:	Re: [rt.cpan.org #32957] Test failure when only JSON::Syck and JSON::Any are installed
Date:	Tue, 30 Jun 2009 01:43:22 -0400
To:	bug-Test-JSON [...] rt.cpan.org
From:	Chris Prather <perigrin [...] gmail.com>

On Tue, Jun 30, 2009 at 12:09 AM, Andreas Koenig via RT<bug-Test-JSON@rt.cpan.org> wrote: Show quoted text

> # Failed test 'use Test::JSON;' > # at t/00-load.t line 6. > # Tried to use 'Test::JSON'. > # Error: Couldn't find a JSON Package. at > /home/sand/.cpan/build/Test-JSON-0.07-XQN8AG/blib/lib/Test/JSON.pm line 7

That error message comes from JSON::Any and looking very quickly at the Test::JSON code I'm gonna claim this one as a JSON::Any bug unless Ovid knows something I don't. I'll take a crack at it tomorrow (or later today depending on your timezone). Show quoted text

> Hope that helps. Please let me know if you need further details about > the involved perl or whatever.

Providing a way to reproduce it was a big help. -Chris

Tue Jun 30 02:08:16 2009 ANDK [...] cpan.org - Correspondence added

For the sake of completeness. I forgot to mention the version of JSON::Any: cpan[6]> m JSON::Any Module id = JSON::Any CPAN_USERID PERIGRIN (Chris Prather <chris@prather.org>) CPAN_VERSION 1.19 CPAN_FILE P/PE/PERIGRIN/JSON-Any-1.19.tar.gz UPLOAD_DATE 2009-01-15 MANPAGE JSON::Any - Wrapper Class for the various JSON classes. INST_FILE /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/JSON/Any.pm INST_VERSION 1.19

Thu Jul 02 17:17:04 2009 chris [...] prather.org - Correspondence added

Subject:	Re: [rt.cpan.org #32957] Test failure when only JSON::Syck and JSON::Any are installed
Date:	Thu, 2 Jul 2009 17:16:43 -0400
To:	bug-Test-JSON [...] rt.cpan.org
From:	Chris Prather <perigrin [...] gmail.com>

On Tue, Jun 30, 2009 at 2:08 AM, Andreas Koenig via RT<bug-Test-JSON@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=32957 > > > For the sake of completeness. I forgot to mention the version of JSON::Any: > > > cpan[6]> m JSON::Any > Module id = JSON::Any > CPAN_USERID PERIGRIN (Chris Prather <chris@prather.org>) > CPAN_VERSION 1.19 > CPAN_FILE P/PE/PERIGRIN/JSON-Any-1.19.tar.gz > UPLOAD_DATE 2009-01-15 > MANPAGE JSON::Any - Wrapper Class for the various JSON classes. > INST_FILE /usr/local/perl-5.10-uld/lib/site_perl/5.10.0/JSON/Any.pm > INST_VERSION 1.19 > > >

Right, Apparently I followed Audrey's advice and deprecated JSON::Syck. Unfortunately in JSON::Any 1.19[1] I made JSON::Syck optional and not implicitly loaded, so I've just released a JSON::Any 1.20 that will (when loading modules implicitly) check for deprecated JSON::* packages and load them with a warning that they're deprecated and people should upgrade to a better supported package. Ovid if you dep on JSON::Any 1.20+ (or any version not JSON::Any 1.19 actually) this bug can be closed. -Chris [1]: If I recall properly the reason I did this was that the new Net::Twitter maint had discovered some encoding bugs in JSON::Syck and asked Audrey. She declined to fix the bugs so I removed it from the list of modules that are checked during implicit loading.

Fri Jul 03 05:26:58 2009 curtis_ovid_poe [...] yahoo.com - Correspondence added

Subject:	Re: [rt.cpan.org #32957] Test failure when only JSON::Syck and JSON::Any are installed
Date:	Fri, 3 Jul 2009 02:26:40 -0700 (PDT)
To:	bug-Test-JSON [...] rt.cpan.org
From:	Ovid <curtis_ovid_poe [...] yahoo.com>

Show quoted text

----- Original Message ----

> From: "chris@prather.org via RT" <bug-Test-JSON@rt.cpan.org> > > Ovid if you dep on JSON::Any 1.20+ (or any version not JSON::Any 1.19 > actually) this bug can be closed.

Right. I've updated this on github, but I can't release yet as there are a couple of minor (internal) issues I need to resolve. I'll try to get to that this weekend. Thanks for your help! Cheers, Ovid -- Buy the book - http://www.oreilly.com/catalog/perlhks/ Tech blog - http://use.perl.org/~Ovid/journal/ Twitter - http://twitter.com/OvidPerl Official Perl 6 Wiki - http://www.perlfoundation.org/perl6

Sat Jul 04 06:45:22 2009 ovid [...] cpan.org - Correspondence added

I've uploaded 0.1 and per our conversation, consider this issue closed. Thanks for your help! Cheers, Ovid

Sat Jul 04 06:45:26 2009 ovid [...] cpan.org - Status changed from 'open' to 'resolved'