Bug #32940 for Devel-REPL: at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"

Tue Feb 05 05:35:04 2008 cedric [...] dreamgnu.com - Ticket created

Subject:

at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"

make test gives an unrecoverable error. see attached file Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"

Subject:

devel_repl.error

Download devel_repl.error
application/octet-stream 4.7k

Message body not shown because it is not plain text.

Wed Feb 13 14:38:42 2008 ntyni [...] iki.fi - Correspondence added

From:

ntyni [...] iki.fi

On Tue Feb 05 05:35:04 2008, cedric@dreamgnu.com wrote: Show quoted text

> make test gives an unrecoverable error. > see attached file > Can't locate object method "update_package_cache_flag" via package > "Devel::REPL::Meta::Plugin"

Hi, this got broken with Moose-0.34. It's also Debian bug #465626, http://bugs.debian.org/465626 I don't claim to really understand half of this, but this patch mimics a similar change in Moose 0.34 and makes the tests pass, so I assume it's the Right Thing to do. Please tell me if I'm wrong. Hope this helps, -- Niko Tyni (Debian Perl Group) ntyni@debian.org

diff --git a/lib/Devel/REPL/Plugin.pm b/lib/Devel/REPL/Plugin.pm index bfa57d3..f2f6d8a 100644 --- a/lib/Devel/REPL/Plugin.pm +++ b/lib/Devel/REPL/Plugin.pm @@ -8,7 +8,7 @@ use Moose::Role (); sub import { my $target = caller; my $meta = Devel::REPL::Meta::Plugin->initialize($target); - $meta->Moose::Meta::Class::add_method('meta' => sub { $meta }); + $meta->alias_method('meta' => sub { $meta }); goto &Moose::Role::import; }

Wed Feb 13 14:38:45 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Feb 13 15:25:09 2008 cedric [...] dreamgnu.com - Correspondence added

Subject:	Re: [rt.cpan.org #32940] at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"
Date:	Wed, 13 Feb 2008 21:23:38 +0100
To:	bug-Devel-REPL [...] rt.cpan.org
From:	Cedric Boudin <cedric [...] dreamgnu.com>

ntyni@iki.fi via RT wrote: The tests do pass now without problems thks cedric Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=32940 > > > On Tue Feb 05 05:35:04 2008, cedric@dreamgnu.com wrote: >

>> make test gives an unrecoverable error. >> see attached file >> Can't locate object method "update_package_cache_flag" via package >> "Devel::REPL::Meta::Plugin" >>

> > Hi, > > this got broken with Moose-0.34. It's also Debian bug #465626, > http://bugs.debian.org/465626 > > I don't claim to really understand half of this, but this patch mimics a > similar change in Moose 0.34 and makes the tests pass, so I assume it's > the Right Thing to do. Please tell me if I'm wrong. > > Hope this helps, > > ------------------------------------------------------------------------ > > diff --git a/lib/Devel/REPL/Plugin.pm b/lib/Devel/REPL/Plugin.pm > index bfa57d3..f2f6d8a 100644 > --- a/lib/Devel/REPL/Plugin.pm > +++ b/lib/Devel/REPL/Plugin.pm > @@ -8,7 +8,7 @@ use Moose::Role (); > sub import { > my $target = caller; > my $meta = Devel::REPL::Meta::Plugin->initialize($target); > - $meta->Moose::Meta::Class::add_method('meta' => sub { $meta }); > + $meta->alias_method('meta' => sub { $meta }); > goto &Moose::Role::import; > } > >

Thu Feb 14 09:09:25 2008 mst [...] shadowcat.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #32940] at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"
Date:	Thu, 14 Feb 2008 14:07:52 +0000
To:	"ntyni [...] iki.fi via RT" <bug-Devel-REPL [...] rt.cpan.org>
From:	Matt S Trout <mst [...] shadowcat.co.uk>

On Wed, Feb 13, 2008 at 02:38:45PM -0500, ntyni@iki.fi via RT wrote: Show quoted text

> > Queue: Devel-REPL > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=32940 > > > On Tue Feb 05 05:35:04 2008, cedric@dreamgnu.com wrote:

> > make test gives an unrecoverable error. > > see attached file > > Can't locate object method "update_package_cache_flag" via package > > "Devel::REPL::Meta::Plugin"

> > Hi, > > this got broken with Moose-0.34. It's also Debian bug #465626, > http://bugs.debian.org/465626 > > I don't claim to really understand half of this, but this patch mimics a > similar change in Moose 0.34 and makes the tests pass, so I assume it's > the Right Thing to do. Please tell me if I'm wrong.

Nope, you just reinvented the exact fix that's already in svn HEAD (http://dev.catalyst.perl.org/repos/bast/trunk/Devel-REPL) I'll cut a release in the next week. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/

Sun Feb 24 12:17:14 2008 sukria [...] sukria.net - Correspondence added

From:

sukria [...] sukria.net

For the record, there's the same issue in ib/Devel/REPL/Plugin/Commands.pm, here's the patch: Index: libdevel-repl-perl/lib/Devel/REPL/Plugin/Commands.pm =================================================================== --- libdevel-repl-perl.orig/lib/Devel/REPL/Plugin/Commands.pm 2008-02-24 16:21:02.000000000 +0100 +++ libdevel-repl-perl/lib/Devel/REPL/Plugin/Commands.pm 2008-02-24 16:21:33.000000000 +0100 @@ -14,7 +14,7 @@ sub BEFORE_PLUGIN { my ($self) = @_; unless ($self->can('setup_commands')) { - $self->meta->add_method('setup_commands' => sub {}); + $self->meta->alias_method('setup_commands' => sub {}); } }

Sat Mar 08 10:40:38 2008 mst [...] shadowcat.co.uk - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #32940] at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"
Date:	Sat, 8 Mar 2008 15:40:05 +0000
To:	Alexis Sukrieh via RT <bug-Devel-REPL [...] rt.cpan.org>
From:	Matt S Trout <mst [...] shadowcat.co.uk>

On Sun, Feb 24, 2008 at 12:17:16PM -0500, Alexis Sukrieh via RT wrote: Show quoted text

> > Queue: Devel-REPL > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=32940 > > > For the record, there's the same issue in > ib/Devel/REPL/Plugin/Commands.pm, here's the patch: > > Index: libdevel-repl-perl/lib/Devel/REPL/Plugin/Commands.pm > =================================================================== > --- libdevel-repl-perl.orig/lib/Devel/REPL/Plugin/Commands.pm > 2008-02-24 16:21:02.000000000 +0100 > +++ libdevel-repl-perl/lib/Devel/REPL/Plugin/Commands.pm > 2008-02-24 16:21:33.000000000 +0100 > @@ -14,7 +14,7 @@ > sub BEFORE_PLUGIN { > my ($self) = @_; > unless ($self->can('setup_commands')) { > - $self->meta->add_method('setup_commands' => sub {}); > + $self->meta->alias_method('setup_commands' => sub {}); > } > }

Don't believe you. Commands BEFORE_PLUGIN $self is the Devel::REPL object, not a role. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/

Thu Apr 09 17:45:18 2009 OLIVER [...] cpan.org - Taken

Thu Apr 09 17:47:52 2009 OLIVER [...] cpan.org - Subject changed from 'at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"' to 'at make test Can't locate object method "update_package_cache_flag" via package "Devel::REPL::Meta::Plugin"'

Thu Apr 09 17:47:52 2009 OLIVER [...] cpan.org - Status changed from 'open' to 'resolved'