Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 32937
Status: resolved
Priority: 0/
Queue: Net-DNS
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.62
Fixed in: (no value)

History Show all quoted text
  Tue Feb 05 03:04:46 2008 ANDK [...] cpan.org - Ticket created
Subject: 5.11 introduces new warning on uc(undef)
Originally reported at http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-01/msg01365.html Now I have found a simple fix and uploaded it to CPAN as ANDK/patches/Net-DNS-0.62-ANDK-01.patch.gz Also pasted here: --- Net-DNS-0.62-jmCPxz.orig/lib/Net/DNS/Question.pm 2007-12-28 20:23:23.000000000 +0100 +++ Net-DNS-0.62-jmCPxz/lib/Net/DNS/Question.pm 2008-02-05 08:44:48.000000000 +0100 @@ -45,8 +45,8 @@ sub new { my $class = shift; my $qname = shift; - my $qtype = uc shift || 'A'; - my $qclass = uc shift || 'IN'; + my $qtype = uc( shift || 'A' ); + my $qclass = uc( shift || 'IN' ); $qname = '' unless defined $qname; # || ''; is NOT same! $qname =~ s/\.+$//o; # strip gratuitous trailing dot I haven't looked why this simple fix also repairs two tests that were actually failing with current bleadperl. Thanks,
  Wed Feb 06 15:22:09 2008 OLAF [...] cpan.org - Correspondence added
Fix to appear in the next release Fix rt.cpan.org #32937 5.11 introduces new warning on uc(undef) The patch supplied fixes for methods where undefined arguments were likely. For methods where undefined arguments don't make the warning will be printed.
  Wed Feb 06 15:22:12 2008 The RT System itself - Status changed from 'new' to 'open'
  Wed Feb 06 15:22:14 2008 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'