Skip Menu |

This queue is for tickets about the XML-Writer CPAN distribution.

Report information
The Basics
Id: 32874
Status: resolved
Priority: 0/
Queue: XML-Writer
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.603
Fixed in: 0.604

History Show all quoted text
  Sat Feb 02 04:34:46 2008 ANDK [...] cpan.org - Ticket created
Subject: new warning in 5.11 on lc(undef) breaks testsuite
With bleadperl's patch 33088 lc(undef) started to issue a warning when warnings are on. This breaks your test suite which apparently relies on lc(undef) work silently. PERL_DL_NONLAZY=1 /home/src/perl/repoperls/installed-perls/perl/pyNdNAp/perl-5.10.0@33154/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_main........... # Failed test '(no warnings)' # at t/01_main.t line 30. # Use of uninitialized value $outputEncoding in lc at /home/sand/.cpan/build/XML-Writer-0.603-AAZYwk/blib/lib/XML/Writer.pm line 63. [...etc...]
  Sat Feb 02 04:52:09 2008 ANDK [...] cpan.org - Correspondence added
Trivial one line patch at ANDK/patches/XML-Writer-0.603-ANDK-01.patch.gz pasted here: --- XML-Writer-0.603/Writer.pm 2007-06-25 23:35:24.000000000 +0200 +++ XML-Writer-0.603-dAehLs/Writer.pm 2008-02-02 10:36:11.000000000 +0100 @@ -58,7 +58,7 @@ $nl = "\n"; } - my $outputEncoding = $params{ENCODING}; + my $outputEncoding = $params{ENCODING} || ""; my ($checkUnencodedRepertoire, $escapeEncoding); if (lc($outputEncoding) eq 'us-ascii') { $checkUnencodedRepertoire = \&_croakUnlessASCII;
  Sat Feb 02 04:52:11 2008 ANDK [...] cpan.org - Status changed from 'new' to 'open'
  Wed Feb 06 16:49:51 2008 joe [...] kafsemo.org - Correspondence added
Thanks, applied in svn. I'll roll out a new version soon.
  Mon Feb 25 14:50:22 2008 joe [...] kafsemo.org - Status changed from 'open' to 'resolved'
  Mon Feb 25 14:51:00 2008 joe [...] kafsemo.org - Fixed in 0.604 added