Skip Menu |

This queue is for tickets about the File-Fetch CPAN distribution.

Report information
The Basics
Id: 32755
Status: resolved
Priority: 0/
Queue: File-Fetch

People
Owner: Nobody in particular
Requestors: thaljef [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 0.14



Subject: File-Fetch tests cannot fail if unable to connect to internet
So I'm merrily installing all the dependencies for CPANPLUS. And when I get to File::Fetch, I see this... ####################### NOTE ############################## Some of these tests assume you are connected to the internet. If you are not, or if certain protocols or hosts are blocked and/or firewalled, these tests will fail due to no fault of the module itself. ########################################################### Our servers are behind a firewall, so naturally, test failures ensue. This is not cool. If the internet is not available, then these tests should be skipped. Or perhaps the LWP interface should be mocked so that a real internet connection is not required. So-called "false-failures" like this are a real problem. Many organizations (like mine) rely on these unit tests to help ensure the health of their system, and we insist on 100% success. Otherwise, we can't make use of great modules like CPANPLUS and File::Fetch.
On Mon Jan 28 22:22:44 2008, THALJEF wrote: Show quoted text
> So I'm merrily installing all the dependencies for CPANPLUS. And when I > get to File::Fetch, I see this... > > ####################### NOTE ############################## > > Some of these tests assume you are connected to the > internet. If you are not, or if certain protocols or hosts > are blocked and/or firewalled, these tests will fail due > to no fault of the module itself. > > ########################################################### > > Our servers are behind a firewall, so naturally, test failures ensue. > This is not cool. If the internet is not available, then these tests > should be skipped.
File::Fetch has been updated to add heuristics for network failures and skip tests accordingly. You can grab File::Fetch 0.15_01 (or newer) from your local CPAN mirror. Thanks for reporting,