| Subject: | Test-Reporter-1.20 patch for cygwin |
Since it's quite common that cygwin people don't have a mailer from Mail::Send installed, I recommend the following patch, so that the number of cygwin tests will increase. Me for example :)
It will fail for cygwin anyway, since Mail::Send is not called the recommended way.
About the mx stuff:
I had to change my cpantest script to change the mx.
I inserted:
$Reporter->from('r.urban@inode.at (Reini Urban cpan:RURBAN)');
$Reporter->mx(['smtp.inode.at']);
--- Test-Reporter-1.20/lib/Test/Reporter.pm~ 2003-03-05 10:15:53.000000000 +0100
+++ Test-Reporter-1.20/lib/Test/Reporter.pm 2003-08-16 16:56:32.000000000 +0200
@@ -355,7 +355,7 @@
if ($recipient =~ /(?:perl|cpan)\.org$/) {
push @tmprecipients, $recipient;
}
- else {
+ elsif ($self->mx->[0] =~ /perl.org/) {
push @bad, $recipient;
}
}
@@ -512,6 +512,7 @@
return $send if defined $send;
return 0 if FAKE_NO_MAIL_SEND;
+ return 0 if $^O =~ /cygwin/;
$send = eval {require Mail::Send};
}