Skip Menu |

This queue is for tickets about the Bio-Trace-ABIF CPAN distribution.

Report information
The Basics
Id: 32597
Status: resolved
Priority: 0/
Queue: Bio-Trace-ABIF

People
Owner: vita [...] cpan.org
Requestors: gilder [...] bioforensics.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Bio::Trace::ABIF
Date: Wed, 23 Jan 2008 16:30:20 -0500
To: bug-bio-trace-abif [...] rt.cpan.org
From: Jason Gilder <gilder [...] bioforensics.com>
Hello Dr. Vitacolonna, I've recently begun using your wonderful Perl module for reading ABI files. Thank you very much for your work on this. My research deals with forensic DNA testing results and this module has helped me develop some new powerful tools. If you are continuing to work on this, I have a short wishlist of features that others may find useful as well. It would be great if you could please add the following: 1) The RFU thresholds used for analysis (based on dye) 2) The first comment field (listed as "Sample Info" in the GeneScan sample information window) 3) The detected peaks from the sample results window in GeneScan (including size, peak height, and peak area) I am currently obtaining the above data by running NCBI's BatchExtract in conjunction with your module (ftp://ftp.ncbi.nlm.nih.gov/pub/forensics/). I would be able to write much faster and more robust software if those features were integrated into the module. Thanks again for all of your work! Jason
[I am posting a reply that I emailed to the OP on May 7, 2008. I got no reply to this so far, so I've set this ticket to 'stalled'] 1) The RFU thresholds used for analysis (based on dye) Could you please provide me with a precise definition of RFU thresholds? 2) The first comment field (listed as "Sample Info" in the GeneScan sample information window) Don't comment() or comment_title() give you such information? 3) The detected peaks from the sample results window in GeneScan (including size, peak height, and peak area) I am not very acquainted with GeneScan, but we have it in the lab, so I may check how such data looks like — but I have to ask again, have you checked whether the methods peak1_location(), peak_area_ratio() or similar will do? Nicola
Ehm, is it so apparent that I'm not very comfortable with this ticketing system? :)
Subject: Re: [rt.cpan.org #32597] Bio::Trace::ABIF
Date: Tue, 12 Jan 2010 16:27:41 -0500
To: bug-Bio-Trace-ABIF [...] rt.cpan.org
From: Jason Gilder <gilder [...] bioforensics.com>
Hi Nicola, Thank you so much for getting back to me. A student in our lab made some changes to obtain the peak information. I haven't had a chance to test it yet (although he has and says it works). I don't believe he's submitted the changes to you. I have attached them here. Let me know if you have any questions. Thanks, Jason Nicola Vitacolonna via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=32597 > > > [I am posting a reply that I emailed to the OP on May 7, 2008. I got no reply to this so far, so > I've set this ticket to 'stalled'] > > 1) The RFU thresholds used for analysis (based on dye) > > Could you please provide me with a precise definition of RFU thresholds? > > 2) The first comment field (listed as "Sample Info" in the GeneScan > sample information window) > > Don't comment() or comment_title() give you such information? > > 3) The detected peaks from the sample results window in GeneScan > (including size, peak height, and peak area) > > I am not very acquainted with GeneScan, but we have it in the lab, so I may check how such > data looks like — but I have to ask again, have you checked whether the methods > peak1_location(), peak_area_ratio() or similar will do? > > Nicola > > > >
=head2 peaks() Usage : @pks = $abif->peaks(1); Returns : An array of peak hashes. Each peak hash contains the following attributes: 'position', 'height', 'beginPos', 'endPos', 'beginHI', 'endHI', 'area', 'volume', 'fragSize', 'isEdited', 'label'; () if the data item is not in the file. ABIF Tag : PEAK ABIF Type : user-defined structure File Type : fsa Returns the data associated with PEAK data structures. =cut sub peaks { my ($self, $n) = @_; my $k = '_PEAK' . $n; my ($position, $height, $beginPos, $endPos, $beginHI, $endHI, $area, $volume, $fragSize, $isEdited, $label); my $s = undef; my @raw_data; my @peak_array; my $i; unless (defined $self->{$k}) { @raw_data = $self->get_data_item('PEAK', $n, '(NnNNnnNNB32nZ64)*'); for ($i = 0; $i < @raw_data; $i += 11) { ($position, $height, $beginPos, $endPos, $beginHI, $endHI, $area, $volume, $s, $isEdited, $label) = @raw_data[$i .. $i+10]; $fragSize = $self->_ieee2decimal($s) if (defined $s); my $peak = {}; $peak->{position} = $position; $peak->{height} = $height; $peak->{beginPos} = $beginPos; $peak->{endPos} = $endPos; $peak->{beginHI} = $beginHI; $peak->{endHI} = $endHI; $peak->{area} = $area; $peak->{volume} = $volume; $peak->{fragSize} = $fragSize; $peak->{isEdited} = $isEdited; $peak->{label} = $label; push @peak_array, $peak; } $self->{$k} = (@peak_array) ? [ @peak_array ] : [ ]; } return @{$self->{$k}}; }
Thanks for the code. I will include it in the next release of the module.