Skip Menu |

This queue is for tickets about the Want CPAN distribution.

Report information
The Basics
Id: 32579
Status: resolved
Priority: 0/
Queue: Want
People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.16
Fixed in: (no value)

History Show all quoted text
  Wed Jan 23 12:34:47 2008 jdhedden [...] cpan.org - Ticket created
Subject: Want broken in blead Perl
Change 33028 to blead changed the location of the .lval element. The attached patch uses the appropriate macro to obtain the lvalue. This change should be backwards compatible.
Subject: want.patch
--- Want.xs.orig 2008-01-23 12:27:54.034441400 -0500 +++ Want.xs 2008-01-23 12:27:57.816175400 -0500 @@ -500,7 +500,7 @@ if (!cx) TOO_FAR; if (CvLVALUE(cx->blk_sub.cv)) - RETVAL = cx->blk_sub.lval; + RETVAL = CxLVAL(cx); else RETVAL = 0; OUTPUT:
  Wed Jan 30 08:27:23 2008 jdhedden [...] cpan.org - Correspondence added
From: jdhedden [...] cpan.org
On Wed Jan 23 12:34:47 2008, JDHEDDEN wrote: Show quoted text
> Change 33028 to blead changed the location of the .lval element. > The attached patch uses the appropriate macro to obtain the lvalue. > This change should be backwards compatible.
I was incorrect about backwards compatibility. Use the attached patch instead.
  Wed Jan 30 08:44:02 2008 jdhedden [...] cpan.org - Correspondence added
JDHEDDEN wrote: Show quoted text
> Change 33028 to blead changed the location of the .lval element. > The attached patch uses the appropriate macro to obtain the lvalue. > This change should be backwards compatible.
Show quoted text
> I was incorrect about backwards compatibility. Use the attached patch > instead.
And, of course, it would help if I actually attached the patch. :)
--- Want-0.16/Want.xs.orig 2008-01-30 08:41:39.383740800 -0500 +++ Want-0.16/Want.xs 2008-01-30 08:42:23.545925400 -0500 @@ -500,7 +500,11 @@ if (!cx) TOO_FAR; if (CvLVALUE(cx->blk_sub.cv)) +#ifdef CxLVAL + RETVAL = CxLVAL(cx); +#else RETVAL = cx->blk_sub.lval; +#endif else RETVAL = 0; OUTPUT:
  Sun Feb 03 13:39:05 2008 ANDK [...] cpan.org - Correspondence added
And then they broke it again in 33057
  Sun Feb 03 13:39:12 2008 The RT System itself - Status changed from 'new' to 'open'
  Sun Feb 03 14:48:40 2008 jdhedden [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #32579] Want broken in blead Perl
Date: Sun, 3 Feb 2008 14:48:19 -0500
To: bug-Want [...] rt.cpan.org
From: "Jerry D. Hedden" <jdhedden [...] cpan.org>
On Feb 3, 2008 1:39 PM, Andreas Koenig via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=32579 > > > And then they broke it again in 33057
Umm, yes. Reported and with patch: http://rt.cpan.org/Public/Bug/Display.html?id=32627
  Mon Feb 04 02:32:31 2008 ANDK [...] cpan.org - Correspondence added
Sorry for the noise, I don't know how I could overlook it. And Thanks for the patches.
  Mon Feb 04 04:42:32 2008 robin [...] cpan.org - Correspondence added
This should be fixed by 0.18.
  Mon Feb 04 04:42:39 2008 robin [...] cpan.org - Status changed from 'open' to 'resolved'