Bug #32542 for DBIx-Class-TimeStamp: Missing support for some PostgreSQL date/time data types...

Tue Jan 22 17:41:51 2008 jasonk [...] cpan.org - Ticket created

Subject:

Missing support for some PostgreSQL date/time data types...

This regexp is a little too restrictive to use effectively with PostgreSQL: if ( $info->{data_type} =~ /^(datetime|date|timestamp)$/i ) { PostgreSQL has three primary date/time data types (timestamp, date, time) and allows you to further specify 'with time zone' or 'without time zone' for the timestamp and time types. 'With time zone' can also be abbreviated just 'tz' (giving timestamptz and timetz) So the regexp should probably be more along the lines of: /^(datetime|date|timestamp|time)(tz|with(out)?\s+time\s+zone)?$/i Although for maximum compatibility, it may be worthwhile to consider just: /(date|time)/

Wed Aug 27 16:29:52 2008 jshirley+cpan [...] gmail.com - Correspondence added

On Tue Jan 22 17:41:51 2008, JASONK wrote: Show quoted text

> This regexp is a little too restrictive to use effectively with

PostgreSQL: Show quoted text

> > if ( $info->{data_type} =~ /^(datetime|date|timestamp)$/i ) { > > PostgreSQL has three primary date/time data types (timestamp, date, > time) and allows you to further specify 'with time zone' or 'without > time zone' for the timestamp and time types. 'With time zone' can also > be abbreviated just 'tz' (giving timestamptz and timetz) > > So the regexp should probably be more along the lines of: > > /^(datetime|date|timestamp|time)(tz|with(out)?\s+time\s+zone)?$/i > > Although for maximum compatibility, it may be worthwhile to consider just: > > /(date|time)/

I took the cue there from DBIx::Class::InflateColumn::TimeStamp, since I do expect that to inflate/deflate. It would be better to check if there is an inflation method, rather than the content type. DBIC::InflateColumn::TimeStamp does: my $type = lc($info->{data_type}); $type = 'datetime' if ($type =~ /^timestamp/); if ($type eq 'datetime' || $type eq 'date') { So, not really any more restrictive than I see with ::TimeStamp, but I do see your point. I just need to keep both of these modules in sync or find some better way to do it. The timezone stuff should be handled in extra => { timezone => '...' } it seems (not 100% sure on that)

Wed Aug 27 16:29:56 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 27 16:30:25 2008 jshirley+cpan [...] gmail.com - Taken

Wed Aug 27 16:32:17 2008 jshirley+cpan [...] gmail.com - Correspondence added

Show quoted text

> I took the cue there from DBIx::Class::InflateColumn::TimeStamp, since I > do expect that to inflate/deflate. >

I mean DBIx::Class::InflateColumn::DateTime... I'm a moron.