Skip Menu |

This queue is for tickets about the ExtUtils-PkgConfig CPAN distribution.

Report information
The Basics
Id: 32426
Status: resolved
Priority: 0/
Queue: ExtUtils-PkgConfig

People
Owner: Nobody in particular
Requestors: djerius [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Support for additional pkg-config functions
The attached, quite simple, patch provides support for the following pkg-config functions: static cflags-only-I cflags-only-other libs-only-other
Subject: ExtUtils-PkgConfig-1.08.patch
# This is a patch for ExtUtils-PkgConfig-1.08.orig to update it to ExtUtils-PkgConfig-1.08 # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -c 'ExtUtils-PkgConfig-1.08.orig/lib/ExtUtils/PkgConfig.pm' 'ExtUtils-PkgConfig-1.08/lib/ExtUtils/PkgConfig.pm' Index: ./lib/ExtUtils/PkgConfig.pm *** ./lib/ExtUtils/PkgConfig.pm Fri Oct 19 16:04:33 2007 --- ./lib/ExtUtils/PkgConfig.pm Fri Jan 18 14:13:57 2008 *************** *** 42,49 **** my $ans = undef; my $arg = shift; ! if (grep {$_ eq $function} qw/libs modversion cflags ! libs-only-L libs-only-l/) { # simple $ans = `pkg-config --$function \"$modulename\"`; --- 42,51 ---- my $ans = undef; my $arg = shift; ! if (grep {$_ eq $function} qw/libs static modversion cflags ! cflags-only-I cflags-only-other ! libs-only-L libs-only-l libs-only-other ! /) { # simple $ans = `pkg-config --$function \"$modulename\"`; #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Fri Jan 18 14:15:46 2008 # Generated by : makepatch 2.00 # Recurse directories : Yes # p 'lib/ExtUtils/PkgConfig.pm' 7590 1200683637 0100644 #### End of ApplyPatch data #### #### End of Patch kit [created: Fri Jan 18 14:15:46 2008] #### #### Checksum: 54 1926 15283 ####
On Fri Jan 18 14:19:56 2008, DJERIUS wrote: Show quoted text
> The attached, quite simple, patch provides support for the following > pkg-config functions: > > static > cflags-only-I > cflags-only-other > libs-only-other
Looks good to me. Marc, OK to commit?
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #32426] Support for additional pkg-config functions
Date: Sun, 20 Jan 2008 16:24:05 +0100
To: Torsten Schoenfeld via RT <bug-ExtUtils-PkgConfig [...] rt.cpan.org>
From: Marc Lehmann <schmorp [...] schmorp.de>
On Sat, Jan 19, 2008 at 10:32:57AM -0500, Torsten Schoenfeld via RT <bug-ExtUtils-PkgConfig@rt.cpan.org> wrote: Show quoted text
> > static > > cflags-only-I > > cflags-only-other > > libs-only-other
> > Looks good to me. Marc, OK to commit?
Oh, I know next to nothing about ExtUtils::PkgConfig, I am cpan maintaienr because I originally uploaded all the packages that sprung out of the Gtk2 pool. Having said that, it looks ok to me :) I can still make a release and upload it if need be, no problem there (but its not looking urgent :). -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / pcg@goof.com -=====/_/_//_/\_,_/ /_/\_\
Subject: Re: [rt.cpan.org #32426] Support for additional pkg-config functions
Date: Sun, 20 Jan 2008 22:06:11 +0100
To: bug-ExtUtils-PkgConfig [...] rt.cpan.org
From: Torsten Schoenfeld <kaffeetisch [...] gmx.de>
On Sun, 2008-01-20 at 10:23 -0500, Marc Lehmann via RT wrote: Show quoted text
> > > static > > > cflags-only-I > > > cflags-only-other > > > libs-only-other
> > > > Looks good to me. Marc, OK to commit?
While writing tests, I realized that "static" needs special treatment: it's only meaningful if used in conjunction with libs: pkg-config --libs --static ... So I added a new command "static-libs" instead. Show quoted text
> Having said that, it looks ok to me :) > > I can still make a release and upload it if need be, no problem there (but > its not looking urgent :).
A new release would still be nice to get these new features and the other test suite fixes out the door. -- Thanks, -Torsten
Subject: Re: [rt.cpan.org #32426] Support for additional pkg-config functions
Date: Mon, 21 Jan 2008 05:48:39 +0100
To: Torsten Schoenfeld via RT <bug-ExtUtils-PkgConfig [...] rt.cpan.org>
From: Marc Lehmann <schmorp [...] schmorp.de>
On Sun, Jan 20, 2008 at 04:08:55PM -0500, Torsten Schoenfeld via RT <bug-ExtUtils-PkgConfig@rt.cpan.org> wrote: Show quoted text
> > I can still make a release and upload it if need be, no problem there (but > > its not looking urgent :).
> > A new release would still be nice to get these new features and the > other test suite fixes out the door.
Just drop me a note when I should (or do it yourself if you want, I think you have all the rights to do that by now?). Either solution is fine by me. -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / pcg@goof.com -=====/_/_//_/\_,_/ /_/\_\
On Sun Jan 20 23:48:58 2008, schmorp@schmorp.de wrote: Show quoted text
> Just drop me a note when I should (or do it yourself if you want, I > think > you have all the rights to do that by now?). Either solution is fine > by > me.
Oh, you're right. I do have the co-maintainer bit now. So I just rolled the release.